From: sashiko-bot@kernel.org
To: "Iván Ezequiel Rodriguez" <ivanrwcm25@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [RESEND PATCH] usb: typec: ucsi: acpi: fix use-after-free on driver removal
Date: Mon, 26 Oct 2026 13:05:54 +0000 [thread overview]
Message-ID: <sashiko-outbox-185266@kernel.org> (raw)
In-Reply-To: <20261026125350.816530-1-ivanrwcm25@gmail.com>
> ucsi_acpi_remove() destroys the UCSI instance before removing the ACPI
> notify handler:
>
> ucsi_unregister(ua->ucsi);
> ucsi_destroy(ua->ucsi);
>
> acpi_remove_notify_handler(...);
>
> ucsi_acpi_notify() dereferences ua->ucsi, so a notify arriving after
> ucsi_destroy() uses freed memory:
>
> CPU0 CPU1
> ---- ----
> ucsi_acpi_remove()
> ucsi_unregister()
> [ ... ]
> Fixes: f56de278e8ec ("usb: typec: ucsi: acpi: Move to the new API")
> Cc: stable@vger.kernel.org
> Reported-by: Fan Wu <fanwu01@zju.edu.cn>
> Link: https://lore.kernel.org/all/20260718021142.3146566-1-fanwu01@zju.edu.cn/
> Signed-off-by: Iván Ezequiel Rodriguez <ivanrwcm25@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261026125350.816530-1-ivanrwcm25@gmail.com?part=1
prev parent reply other threads:[~2026-10-26 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 12:53 [RESEND PATCH] usb: typec: ucsi: acpi: fix use-after-free on driver removal Iván Ezequiel Rodriguez
2026-10-26 13:05 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-185266@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ivanrwcm25@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox