From: sashiko-bot@kernel.org
To: hsyysy@163.com
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: phy: generic: request the vbus supply only when it is described
Date: Mon, 26 Oct 2026 14:57:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-185415@kernel.org> (raw)
In-Reply-To: <20261026144800.1392738-1-hsyysy@163.com>
> From: Yang Siyuan <hsyysy@163.com>
>
> usb_phy_gen_create_phy() unconditionally asks for an exclusive "vbus"
> regulator. The legacy usb_phy_generic platform device registered by USB
> glue drivers (e.g. sunxi MUSB) has no firmware node, so the lookup ends
> up in the dummy-regulator path and the regulator core warns:
>
> usb_phy_generic usb_phy_generic.1.auto: dummy supplies not allowed for
> exclusive requests (id=vbus)
>
> Only issue the request when the device firmware actually describes a
> vbus-supply, and keep treating -ENODEV as "not present".
>
> Signed-off-by: Yang Siyuan <hsyysy@163.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261026144800.1392738-1-hsyysy@163.com?part=1
prev parent reply other threads:[~2026-10-26 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 14:48 [PATCH] usb: phy: generic: request the vbus supply only when it is described hsyysy
2026-10-26 14:57 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-185415@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=hsyysy@163.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox