Re: [PATCH 2/7] usb: storage: ene_ub6250: report boot block errors

[sashiko-bot@kernel.org]

> From: Josef Bacik <josef@toxicpanda.com>
> 
> A Memory Stick whose boot block is rejected by the ENE UB6250 driver,
> for instance a hybrid card or a card with an unexpected class, page size
> or IDI configuration, crashes the kernel with a NULL pointer
> write when it is inserted.
> 
> ms_lib_process_bootblock() unconditionally sets result to 0 just before
> returning, so every failure is reported as success.  On those failures
> the logical maps were either never allocated, or were freed again by
> ms_lib_free_logicalmap() at its exit label, so ms_card_init() then
> writes through a NULL Phy2LogMap:
> 
>     info->MS_Lib.Phy2LogMap[btBlk1st] = MS_LB_BOOT_BLOCK;
> 
> It also means the second boot block is never tried when the first one is
> bad.
> 
> The bug was found by code inspection and has not been reproduced.
> 
> Fix by returning the real result from ms_lib_process_bootblock(), so
> that ms_card_init() falls back to the second boot block and fails when
> neither one is usable.
> 
> Fixes: 33842cedfc33 ("Staging: Merge ENE UB6250 MS card codes from keucr to drivers/usb/storage/ene_ub6250.c")
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027-llm-usb-storage-v1-0-d1655e94ed10@linuxfoundation.org?part=2