Re: [PATCH 16/19] usb: renesas_usbhs: link URBs with interrupts disabled

[sashiko-bot@kernel.org]

> From: Josef Bacik <josef@toxicpanda.com>
> 
> usb_hcd_link_urb_to_ep() and usb_hcd_unlink_urb_from_ep() are to be
> called under the lock of the host controller driver, with interrupts
> disabled. They take hcd_urb_list_lock with a plain spin_lock().
> 
> usbhsh_urb_enqueue() calls the first one without any lock, with
> interrupts enabled if the URB was submitted from process context.
> usbhsh_queue_done() calls the second one, mostly from the interrupt
> handler of the controller.
> 
> The host mode is used on a uniprocessor board, where the spinlock is
> nothing. There the interrupt for a finished URB can come in the middle of
> the list_add_tail() for the next URB of the same endpoint, and its
> list_del_init() leaves the list of the endpoint corrupted. On an SMP
> kernel the CPU would wait for itself instead.
> 
> usbhsh_queue_done() is also called from usbhsh_urb_dequeue() with
> interrupts enabled.
> 
> Take the lock of the driver around both calls.
> 
> Fixes: 034d7c13a79c ("usb: gadget: renesas_usbhs: add mod_host support")
> Cc: stable <stable@kernel.org>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027-llm-usb-v1-0-b9751ddb9c7c@linuxfoundation.org?part=16