Re: [PATCH v2 1/2] usb: ehci-pci: Skip SBRN and port-wake reads on Intel CE5300

[sashiko-bot@kernel.org]

> From: Joseph Telaak <joseph@telaak.dev>
> 
> The TDI EHCI core in the Intel CE5300 SoCs (192e:0101, revision >= 6)
> has no EHCI-specific PCI config registers at 0x60: those bytes shadow
> BAR3. ehci_pci_setup() reads two of them anyway.
> 
> SBRN (0x60) reads as 0 and overwrites the HCD_USB2 default, so the
> controller reports "USB 0.0 started" and ehci_shutdown() returns
> early because sbrn is 0, so the controller is never stopped on reboot
> or kexec. The port-wake word (0x62) is whatever BAR3 holds, so on
> some instances bit 0 is set and the driver prints "Enabling legacy
> PCI PM" and marks the controller wakeup-capable.
> 
> Skip both reads for this core, as is already done for SBRN on the ST
> ConneXT and HiSilicon Kunpeng920 controllers. The new helper is also
> used by the next patch.
> 
> Tested on a Control4 EA-3 (Intel Atom CE5310) with v7.3-rc6: the
> controllers report "USB 2.0 started" and the legacy PCI PM message is
> gone.
> 
> Assisted-by: LLM
> Signed-off-by: Joseph Telaak <joseph@telaak.dev>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027-ehci-ce5300-hostpc-v2-0-375e9d362d74@telaak.dev?part=1