From: sashiko-bot@kernel.org
To: mdshahid03@gmail.com
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: legousbtower: use stream_open for stream semantics
Date: Wed, 28 Oct 2026 18:32:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-188294@kernel.org> (raw)
In-Reply-To: <20261028182802.25212-1-mdshahid03@gmail.com>
> From: Mohammad Shahid <mdshahid03@gmail.com>
>
> The LEGO USB Tower driver uses nonseekable_open() in tower_open()
> However, its read and write have stream semantics.
>
> Use stream_open instead to mark the file as a stream and disable
> unnecessary file position handling.
>
> The issue is reported by stream_open.cocci script as potential
> deadlock between read and write operation.
>
> Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261028182802.25212-1-mdshahid03@gmail.com?part=1
prev parent reply other threads:[~2026-10-28 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 18:28 [PATCH] USB: legousbtower: use stream_open for stream semantics mdshahid03
2026-10-28 18:32 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-188294@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdshahid03@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox