From: sashiko-bot@kernel.org
To: "Mario Limonciello" <superm1@kernel.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] USB: hub: call ACPI _PRR reset during port power-cycle on enumeration failure
Date: Tue, 03 Nov 2026 06:18:35 +0000 [thread overview]
Message-ID: <sashiko-outbox-194613@kernel.org> (raw)
In-Reply-To: <20260706080117.3754550-1-v3-1-0e3069228fe9@kernel.org>
> Some USB-connected devices (e.g. MT7925 Bluetooth on Dell laptops) expose
> their hardware reset line via an ACPI Power Resource for Reset (_PRR)
> rather than relying solely on VBUS cycling for recovery. When the reset
> GPIO gets stuck low the device stops responding on USB; a VBUS power-cycle
> alone cannot recover it because the chip remains in reset regardless of
> VBUS state.
>
> Add usb_acpi_port_prr_reset() in usb-acpi.c that, given a hub device and
> one-based port number, looks up the port's ACPI companion handle, evaluates
> _PRR to obtain the power-resource reference, and then calls _RST on that
> reference to toggle the reset line. The function is a no-op if the port
> has no ACPI handle or no _PRR method, so it is safe to call unconditionally
> for every port.
>
> Wire it into hub_port_connect() during the mid-retry VBUS power-cycle
> [ ... ]
>
> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> Link: https://patch.msgid.link/20260706080117.3754550-1-acelan.kao@canonical.com
> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260706080117.3754550-1-v3-1-0e3069228fe9@kernel.org?part=1
prev parent reply other threads:[~2026-11-03 6:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 6:08 [PATCH v3] USB: hub: call ACPI _PRR reset during port power-cycle on enumeration failure Mario Limonciello
2026-11-03 6:18 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194613@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox