Re: [PATCH] usb: gadget: uvc: fix dwFrameInterval array leak on frame removal

[sashiko-bot@kernel.org]

> uvcg_frame_dw_frame_interval_store() allocates the frame interval array
> and stores it in uvcg_frame::dw_frame_interval. The array is only freed
> when it is replaced by a later write to the dwFrameInterval attribute.
> 
> Frame items use the generic uvcg_config_item_release(), which frees the
> frame itself but not the interval array, so the array is leaked every
> time a frame directory is removed after dwFrameInterval was written.
> This happens on every normal teardown of a configfs UVC gadget, and
> kmemleak reports it as:
> 
>   unreferenced object 0xffff8881027f5040 (size 8):
>     comm "uvc-frame-inter", pid 281, jiffies 4294827366
>     hex dump (first 8 bytes):
>       15 16 05 00 00 00 00 00                          ........
>     backtrace (crc 60980708):
> [ ... ]
> functions in a VM.
> 
> Fixes: 46919a23ee87 ("usb: gadget: uvc: configfs support in uvc function")
> Cc: stable@vger.kernel.org
> Signed-off-by: Priyanka Mani <priyankamani2100@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/7f7db2bcb2c5d248cf72a270bd18afc71cf01559.1793687064.git.priyankamani2100@gmail.com?part=1