From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793718080; b=dyh3+A/NZRhkg9nxP/mDJE5cEPJkMItbAnFgTt3BcDNJMOOn6JgT0CX8mX7FjsQBxKuG /9fImd4gZjcKwlf84zj8kqPCQtveLjNLP/tsBOk4fRc6uC2JPECDBC/Xaqj5TqENPJOIb jzAMOsevvp/WmeeIxDCXHJe5LbwRyp/4oKNej4ooSiFczFwKlDgQT33C5y7WQn0WTkK55 fVmitoweZ+0OhR0Lo6Ei9H3r/z6tRVWmCLXIu6PJ1VbL0KLNbJ2ft2Ez66yZpc5Fn4I1m 6+Dktz5HkHNcxkyr9vv3eNBtv9uBkrWBe637ST2VZk/WJ5EBZkzOxTuZZ/PJFV/ymgA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793718080; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=pruwCsX2Nj8P2A3ZkDZfqhhveDP+NyBs8rSomhgGUU8=; b=3tqHVLr0B/6JuPGul12JNszbThmletz7uA6N1EpVJ2ouM+YqPofC6NF6+t81ZsyHSy/M 1WvdtTAkEEy3OFLeXvtkSNCFM/cZfWIU2SgsNjlXvwARJ5I4Yi7Wt3DA4z4tnlmCSDOs+ ouDBDQZC4HO9+hAoCJivcYLyAvhfJThKihJ3sjNvdQ7R/cqFunbe1lVyA9yUsV+uiPDOw 5CUafEl2aTvc7yH9qJNZIFQ1zdFmlUQIEFTt4EacaEssSU+/zGxdsJouHUfIyAyzLyPF6 NHDLQNCdsnRY5bC3yMFwghIs2pITTmV8o+2Q7rgXY9FUFWqWL2qW+uLk/Xn2tMmzJZQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=gpYfA8iv; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7FC660A262C; Tue, 3 Nov 2026 15:01:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=gpYfA8iv Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCD2A1F000C1; Tue, 3 Nov 2026 15:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793718079; bh=pruwCsX2Nj8P2A3ZkDZfqhhveDP+NyBs8rSomhgGUU8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=gpYfA8ivu0EAnWhduZFmphtcIFZSGsJJkhZlvzy5YyKRExQz2lKkkw8OFY07G7zhl QXK+/wAx2e3lUZBCumPvDuR1/CWFBc91Z6WG2Hpe/KA3keAWuqHeKEckj6rl+uRvUm 0DD2mqqO1kQPWJtMH9mgPG2OwfUnYuJ9j6ikz9y+dNaFMbCTYjhiXpIP4eWCi5yjYi Hz31AyUaH/D1IdodghQ/+cQxG+cvoF7GjEMSxwIAcogBIdrkyj4oC8VJmOIa5uaDa8 BqiLNz4agF5A0jKeip5ntCNO+LfhUsYbiRyktw0MpTevQA8rbeHsgsbIZcoz3mCr6C TOSw9p+fDzh/g== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC 08/16] selftests/proc: check that a faulting reader doesn't hold up removal Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-mm@kvack.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, sparclinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-input@vger.kernel.org, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, dmitry.torokhov@gmail.com, "Petr Pavlu" , "Anna Schumaker" , yukuai@fygo.io, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261102-work-procfs-core-v1-8-75df35e4f8b8@kernel.org> References: <20261102-work-procfs-core-v1-0-75df35e4f8b8@kernel.org> <20261102-work-procfs-core-v1-8-75df35e4f8b8@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 03 Nov 2026 15:01:17 +0000 X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] selftests/proc: Makefile and .gitignore entries in wrong commit -- commit 9de4ed28fcd6656e6c6c2bb55f1514d9aa6600f6 Author: Christian Brauner selftests/proc: check that a faulting reader doesn't hold up removal This commit adds a selftest in tools/testing/selftests/proc/proc-remove-slo= w-reader.c that verifies removing a /proc/net/dev_snmp6/ entry does not block whe= n a concurrent reader faults while copying to userspace via userfaultfd. > diff --git a/tools/testing/selftests/proc/proc-remove-slow-reader.c b/too= ls/testing/selftests/proc/proc-remove-slow-reader.c > new file mode 100644 > index 0000000000000..a201645beca9d > --- /dev/null > +++ b/tools/testing/selftests/proc/proc-remove-slow-reader.c > @@ -0,0 +1,133 @@ [ ... ] > +TEST(remove_while_reader_faults) > +{ [Severity: Low] Should this commit also include the corresponding tools/testing/selftests/p= roc/Makefile and tools/testing/selftests/proc/.gitignore entries for proc-remove-slow-re= ader? In the current series, those entries: tools/testing/selftests/proc/Makefile: TEST_GEN_PROGS +=3D proc-remove-slow-reader tools/testing/selftests/proc/.gitignore: /proc-remove-slow-reader were placed in the earlier commit ("selftests/proc: check that a faulting readlink() doesn't hold up removal") before proc-remove-slow-reader.c exist= s. Building tools/testing/selftests/proc at that earlier commit or any interme= diate commit before this one fails due to the missing source file, breaking bisec= tion, and cherry-picking this commit on its own leaves the new test unbuilt. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261102-work-procf= s-core-v1-0-75df35e4f8b8@kernel.org?part=3D8