From: sashiko-bot@kernel.org
To: "Kyle Farrell" <kaf@nwlink.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 2/3] usb: gadget: u_audio: pass channel counts explicitly
Date: Tue, 03 Nov 2026 21:24:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-196051@kernel.org> (raw)
In-Reply-To: <20261103211434.996135-3-kaf@nwlink.com>
> u_audio currently derives the channel count from the channel mask in
> struct uac_params in several places. Instead, pass the resolved count
> explicitly, so the shared audio implementation does not depend on how
> an individual USB audio function represents its channel configuration.
>
> Initialize the channel counts from the existing masks in f_uac1 and
> f_uac2. Remove the now-unused channel mask fields from uac_params.
> Preserve existing behavior.
>
> Signed-off-by: Kyle Farrell <kaf@nwlink.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103211434.996135-1-kaf@nwlink.com?part=2
next prev parent reply other threads:[~2026-11-03 21:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 21:14 [PATCH v3 0/3] usb: gadget: f_uac2: allow explicit channel count independent of channel mask Kyle Farrell
2026-11-03 21:14 ` [PATCH v3 1/3] usb: gadget: f_uac2: avoid truncating calculated bandwidth Kyle Farrell
2026-11-03 21:25 ` sashiko-bot
2026-11-03 21:14 ` [PATCH v3 2/3] usb: gadget: u_audio: pass channel counts explicitly Kyle Farrell
2026-11-03 21:24 ` sashiko-bot [this message]
2026-11-03 21:14 ` [PATCH v3 3/3] usb: gadget: f_uac2: allow explicit channel count independent of channel mask Kyle Farrell
2026-11-03 21:24 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-196051@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kaf@nwlink.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox