Re: [PATCH] usb: cdns3: drop the second function reference after use

[sashiko-bot@kernel.org]

> cdns3_get_second_fun() returns a struct pci_dev obtained with
> pci_get_device(), which takes a reference on the device, and both
> cdns3_pci_probe() and cdns3_pci_remove() keep that reference until they
> return without ever dropping it.  Probing or removing either function of
> the USBSS controller therefore pins the sibling PCI device and its
> driver's module forever.  cdns3_get_second_fun() also leaks the
> reference itself when the device it finds is not one of the two expected
> functions.
> 
> Release the reference on every path that gives up ownership: in the
> error return of cdns3_get_second_fun(), and at the end of the probe and
> remove callbacks.
> 
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104021453.1468443-1-vulab@iscas.ac.cn?part=1