Re: [PATCH 3/3] usb: dwc2: Handle OTG interrupts that GINTSTS does not flag

[sashiko-bot@kernel.org]

> From: Chuanhong Guo <gch981213@gmail.com>
> 
> The DWC OTG 3.30a found on Siflower SF19A2890 has battery charger
> support enabled. It triggers MultVallpChng interrupt (bit 20 of
> GOTGINT) but doesn't set OTGInt in GINTSTS. As a result, this
> interrupt is never handled, and Linux disables USB interrupt
> because "nobody cares".
> 
> Handle OTG interrupt in IRQ handler regardless of whether the
> OTGInt bit in GINTSTS is set or not.
> 
> On a GL.iNet GL-SFT1200 it shows differently: after a few replugs of a
> USB stick the system stops making progress, the console repeating its
> last message with the same timestamp, until a power cycle.
> 
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
> [jt: only on cores with the new otg_int_unflagged parameter, which
>  SF19A2890 sets, in the one place that already handles flagged OTG
>  interrupts and with IRQ_HANDLED returned; the others still handle OTG
>  interrupts only when GINTSTS flags them; what a GL-SFT1200 does without
>  the patch, subject]
> Signed-off-by: Joseph Telaak <joseph@telaak.dev>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-sf19a2890-dwc2-v1-0-d959375e26ab@telaak.dev?part=3