Re: [PATCH v1 3/3] ACPI: glue: Simplify struct acpi_dev_type and its usage

[sashiko-bot@kernel.org]

> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> 
> All of the current users of struct acpi_dev_type match the device type
> in their .match() callbacks and all of them use const device type
> pointers for that which means that the structure can be simplified and
> used in a more straightforward way.
> 
> Namely, modify struct acpi_dev_type to contain a const device type
> pointer instead of the .match() callback and remove the name field
> from it.  Next, update the users of struct acpi_dev_type to register
> a separate object of that type for each device type that requires an
> ACPI companion lookup.
> 
> Since the register_acpi_dev_type() and unregister_acpi_dev_type()
> function bodies are rewiritten entirely anyway, make them use
> guard(rwsem_write) instead of down_write()/up_write() pairs and
> print the messages under the semaphore to ensure that the struct
> acpi_dev_type objects they refer to will not be freed prematurely.
> 
> No intentional functional impact beyond messaging.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/3471545.44csPzL39Z@rafael.j.wysocki?part=3