Re: [PATCH 1/5] xhci: keep port link_inactive and connected flags in sync when polled

[sashiko-bot@kernel.org]

> Update port 'link_inactive' and 'connected' flags even if xHC isn't
> generating port change events.
> 
> xHC only generates port change events on port changes after old port
> change bits are cleared. Hub driver is often kept up to date
> by polling the port status.
> 
> Sashiko reported a possible case where all port changes after a port
> reset take place before hub driver clears the reset change bit.
> This way the port can end up connected and fully running with link
> in u0 without a port event clearing the 'link_inactive' or setting
> the 'connected' flags.
> 
> A protocol STALL in this state would set EP_DROP_PENDING, and
> prevent all future URBs for the endpoint.
> 
> Fix this by also updating the flags during get_port_status(), when
> hub driver is polling the port state.
> 
> Fixes: 6895dbdc19d9 ("xhci: give back TDs and clean up ep0 after disconnect")
> Link: https://lore.kernel.org/linux-usb/sashiko-outbox-190046@kernel.org/
> Cc: stable <stable@kernel.org>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105175106.241182-1-mathias.nyman@linux.intel.com?part=1