Re: [PATCH 24/25] riscv: add Metanoia MT2824 SoC and MT5824 EVB support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] riscv: dts: metanoia: invalid uart0/uart1 aliases in
  mt5824-evb.dts
--

commit 9f82e60e9d27daf0d2b50c91457b33d4fb60e507
Author: Benoît Monin <benoit.monin@bootlin.com>

riscv: add Metanoia MT2824 SoC and MT5824 EVB support

This commit adds device tree files for the Metanoia MT2824 SoC and the
MT5824 evaluation board.

> diff --git a/arch/riscv/boot/dts/metanoia/mt5824-evb.dts b/arch/riscv/boot/dts/metanoia/mt5824-evb.dts
> new file mode 100644
> index 0000000000000..d0e8eb0a49a43
> --- /dev/null
> +++ b/arch/riscv/boot/dts/metanoia/mt5824-evb.dts
> @@ -0,0 +1,81 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2026 Metanoia Communications Inc.. All rights reserved.
> + */
> +
> +/dts-v1/;
> +
> +#include "mt2824.dtsi"
> +
> +/ {
> +	model = "Metanoia MT5824 EVB";
> +	compatible = "metanoia,mt5824-evb", "metanoia,mt2824";
> +
> +	aliases {
> +		uart0 = &serial0;
> +		uart1 = &serial1;
> +		spi0 = &spi0;
> +		spi1 = &spi1;
> +		spi2 = &spi2;
> +	};
> +
> +	chosen {
> +		stdout-path = "uart0:115200n8";
> +	};

[Severity: Medium]
Should the UART aliases in /aliases and stdout-path be named serial0 and
serial1 instead of uart0 and uart1?

The devicetree serial binding (serial.yaml) requires UART aliases to use
the serialN naming convention, so uart0 and uart1 fail dtbs_check
validation.  In addition, __uart_read_properties() looks up the "serial"
alias stem via of_alias_get_id(dev_of_node(dev), "serial") when assigning
port->line, causing the uart0 and uart1 alias indices to be ignored.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-mt2824-v1-0-86087eaf5af4@bootlin.com?part=24