Re: [PATCH] USB: visor add vendor/device IDs for PalmSource devices from the PalmUSBD.inf file in Palm Desktop 6.2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] USB: visor: build failure from PALMSOURCE_DEVICES_*_ID macro
  name mismatch
--

commit d0c97779f759102eedae826693bbb99e9485b9f6
Author: Adam Simonelli <adamsimonelli@gmail.com>

USB: visor add vendor/device IDs for PalmSource devices from the PalmUSBD.inf file in Palm Desktop 6.2

This commit adds USB vendor and product IDs for two PalmSource devices to
the visor driver.

> diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
> index 4412834db21c5..badc1af72b569 100644
> --- a/drivers/usb/serial/visor.c
> +++ b/drivers/usb/serial/visor.c
> @@ -79,6 +79,10 @@ static const struct usb_device_id id_table[] = {
>  		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
>  	{ USB_DEVICE(PALM_VENDOR_ID, PALM_ZIRE_ID),
>  		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
> +	{ USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_1_ID),
> +		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
> +	{ USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_2_ID),
> +		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
>  	{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_4_0_ID),
>  		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
>  	{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_S360_ID),
> @@ -137,6 +141,8 @@ static const struct usb_device_id id_table_combined[] = {
>  	{ USB_DEVICE(PALM_VENDOR_ID, PALM_TREO_650) },
>  	{ USB_DEVICE(PALM_VENDOR_ID, PALM_TUNGSTEN_Z_ID) },
>  	{ USB_DEVICE(PALM_VENDOR_ID, PALM_ZIRE_ID) },
> +	{ USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_1_ID) },
> +	{ USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICES_2_ID) },
>  	{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_3_5_ID) },
>  	{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_4_0_ID) },
>  	{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_S360_ID) },
> diff --git a/drivers/usb/serial/visor.h b/drivers/usb/serial/visor.h
> index 622d639ce74e0..0f86bd06c4fe4 100644
> --- a/drivers/usb/serial/visor.h
> +++ b/drivers/usb/serial/visor.h
> @@ -32,6 +32,10 @@
>  #define PALM_ZIRE_ID			0x0070
>  #define PALM_M100_ID			0x0080
>  
> +#define PALMSOURCE_VENDOR_ID		0x13e8
> +#define PALMSOURCE_DEVICE_1_ID		0x0600
> +#define PALMSOURCE_DEVICE_2_ID		0xff00
> +
>  #define GSPDA_VENDOR_ID		0x115e
>  #define GSPDA_XPLORE_M68_ID		0xf100

[Severity: High]
Does this break the build when CONFIG_USB_SERIAL_VISOR is enabled?
visor.h defines PALMSOURCE_DEVICE_1_ID and PALMSOURCE_DEVICE_2_ID, while
id_table and id_table_combined in visor.c reference the undeclared plural
names PALMSOURCE_DEVICES_1_ID and PALMSOURCE_DEVICES_2_ID.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106230755.2652311-1-adamsimonelli@gmail.com?part=1