From: sashiko-bot@kernel.org
To: "Jing Lin" <kayano050408@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v8 4/4] usb: gadget: gadgetfs: avoid writing through the const setup pointer
Date: Tue, 10 Nov 2026 04:18:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-206184@kernel.org> (raw)
In-Reply-To: <20261110-gadgetfs-ep0-v8-v8-4-8f90434574fe@gmail.com>
> From: Jing Lin <kayano050408@gmail.com>
>
> gadgetfs_setup() receives the setup packet as const, but clamps an
> oversized control IN request by casting away the constness and writing
> the truncated length back into the caller's wLength field.
>
> The setup() callback has no business modifying the setup packet, and
> ctrl->wLength is only used afterwards when initializing event->u.setup.
> Store the clamped w_length into event->u.setup.wLength directly instead.
>
> Suggested-by: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Jing Lin <kayano050408@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-gadgetfs-ep0-v8-v8-0-8f90434574fe@gmail.com?part=4
next prev parent reply other threads:[~2026-11-10 4:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 4:13 [PATCH v8 0/4] usb: gadget: gadgetfs: fix ep0 request lifetime and event counter Jing Lin via B4 Relay
2026-11-10 4:13 ` [PATCH v8 1/4] usb: gadget: gadgetfs: fix ep0 request lifetime and buffer races Jing Lin via B4 Relay
2026-11-10 4:40 ` sashiko-bot
2026-11-10 4:13 ` [PATCH v8 2/4] usb: gadget: gadgetfs: fix ep0 setup abort and unbind state races Jing Lin via B4 Relay
2026-11-10 4:36 ` sashiko-bot
2026-11-10 4:13 ` [PATCH v8 3/4] usb: gadget: gadgetfs: prevent ep0 event counter underflow Jing Lin via B4 Relay
2026-11-10 4:34 ` sashiko-bot
2026-11-10 4:13 ` [PATCH v8 4/4] usb: gadget: gadgetfs: avoid writing through the const setup pointer Jing Lin via B4 Relay
2026-11-10 4:18 ` sashiko-bot [this message]
2026-11-10 22:49 ` [PATCH v8 0/4] usb: gadget: gadgetfs: fix ep0 request lifetime and event counter Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-206184@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kayano050408@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox