From: sashiko-bot@kernel.org
To: LiuJunyuan <2058432396@qq.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: udc: handle NULL request in tracepoint
Date: Wed, 11 Nov 2026 05:05:40 +0000 [thread overview]
Message-ID: <sashiko-outbox-208322@kernel.org> (raw)
In-Reply-To: <tencent_924108DBAEA30F3DD09C66FEC41A965A970A@qq.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] usb: gadget: udc: single-word name in Signed-off-by trailer
--
commit 6804b1034e0597891cfe25f25e74344c3996cdb7
Author: LiuJunyuan <2058432396@qq.com>
> usb: gadget: udc: handle NULL request in tracepoint
>
> usb_ep_alloc_request() passes a NULL request to
> trace_usb_ep_alloc_request() when ep->ops->alloc_request() fails.
> The udc_log_req tracepoint assumes req is non-NULL and dereferences
> req->length, causing a NULL pointer dereference.
>
> Make the tracepoint handle req == NULL so allocation failures can still
> be recorded safely.
>
> Reported-by: syzbot+2a7ce560c30c4ca3bc22@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=2a7ce560c30c4ca3bc22
> Fixes: 5e42d710a108 ("usb: gadget: add tracepoints to the gadget API")
> Signed-off-by: LiuJunyuan <2058432396@qq.com>
[Severity: High]
The Author and Signed-off-by lines use a single-word name ("LiuJunyuan")
without a space between the family name and given name. Per
Documentation/process/submitting-patches.rst, DCO sign-off requires a
space-separated full real name (e.g., "Liu Junyuan" or "Junyuan Liu").
--
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_924108DBAEA30F3DD09C66FEC41A965A970A@qq.com?part=1
next prev parent reply other threads:[~2026-11-11 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 4:50 [PATCH] usb: gadget: udc: handle NULL request in tracepoint LiuJunyuan
2026-11-11 5:05 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-11 6:28 Liu Junyuan
2026-11-11 6:36 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208322@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=2058432396@qq.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox