Re: [PATCH v2 3/3] usb: dwc2: Handle OTG interrupts that GINTSTS does not flag

[sashiko-bot@kernel.org]

> From: Chuanhong Guo <gch981213@gmail.com>
> 
> The DWC OTG 3.30a of the Siflower SF19A2890 has battery charger support
> enabled. It raises the MultValIpChng interrupt (bit 20 of GOTGINT)
> without setting OTGInt in GINTSTS, so the interrupt is never handled
> and the kernel disables the USB interrupt because nobody cared.
> 
> On a GL.iNet GL-SFT1200 it shows differently: after a few replugs of a
> USB stick the system stops making progress, the console repeating its
> last message with the same timestamp, until a power cycle.
> 
> Add an otg_int_unflagged parameter for such cores. With it set, the
> common interrupt handler also reads GOTGINT on every interrupt and
> handles any OTG interrupt it finds there, as it does when OTGInt is
> set. The SF19A2890 sets it; other cores are unchanged.
> 
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
> [Joseph Telaak:
>   - handle the unflagged OTG interrupts only on cores with the new
>     otg_int_unflagged parameter, which the SF19A2890 sets
>   - do it in the one place that already handles flagged OTG
>     interrupts, and return IRQ_HANDLED
>   - describe what a GL-SFT1200 does without the patch, and the fix as
>     it is now
>   - subject]
> Co-developed-by: Joseph Telaak <joseph@telaak.dev>
> Signed-off-by: Joseph Telaak <joseph@telaak.dev>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-sf19a2890-dwc2-v2-0-cba9dd4a4256@telaak.dev?part=3