Linux USB
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arun Iyengar" <aiyengar1990@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] usb: dwc3: rockchip: Keep the host bus across suspend-to-idle on RK3588
Date: Thu, 12 Nov 2026 08:56:33 +0000	[thread overview]
Message-ID: <sashiko-outbox-210801@kernel.org> (raw)
In-Reply-To: <20261112-dwc3-s2idle-optin-v1-2-842e3f8413d0@gmail.com>

> From: Arun Iyengar <aiyengar1990@gmail.com>
> 
> On RK3588 nothing powers the USB3 controllers down in suspend-to-idle:
> this glue has no system sleep work of its own, the controllers are
> either in PD_USB, which has GENPD_FLAG_ACTIVE_WAKEUP and so stays on for
> a device on the awake path, or (USB3OTG2) in no power domain at all.
> Tearing the core down there only ends the power sessions of the
> suspended devices: on an Orange Pi 5 a SanDisk Extreme drive and a card
> reader behind a USB3 hub are disconnected and enumerated again after
> every resume, which kills a filesystem mounted on them.
> 
> Set keep_host_bus_in_s2idle for RK3588, so the core keeps the suspended
> bus in suspend-to-idle. RK3576 is left as it is: its second controller
> is in PD_PHP, which is switched off in suspend-to-idle.
> 
> Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-dwc3-s2idle-optin-v1-0-842e3f8413d0@gmail.com?part=2


  reply	other threads:[~2026-11-12  8:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  8:35 [PATCH RFC 0/2] usb: dwc3: Let the Rockchip glue keep the host bus across suspend-to-idle Arun Iyengar via B4 Relay
2026-11-12  8:35 ` [PATCH RFC 1/2] usb: dwc3: Let the glue keep the host bus suspended " Arun Iyengar via B4 Relay
2026-11-12  8:49   ` sashiko-bot
2026-11-12  8:35 ` [PATCH RFC 2/2] usb: dwc3: rockchip: Keep the host bus across suspend-to-idle on RK3588 Arun Iyengar via B4 Relay
2026-11-12  8:56   ` sashiko-bot [this message]
2026-11-12  8:39 ` [PATCH RFC 0/2] usb: dwc3: Let the Rockchip glue keep the host bus across suspend-to-idle Arun Iyengar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-210801@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=aiyengar1990@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox