Re: [PATCH v2 1/3] usb: uas: complete command on status URB error

[sashiko-bot@kernel.org]

> When a UAS device is unplugged while hub_wq is frozen during system
> suspend, usb_disconnect() is deferred and sd_sync_cache() issues
> SYNCHRONIZE_CACHE to the disconnected target. If the status URB fails in
> uas_stat_cmplt(), uas_stat_cmplt() logs the error and frees the URB
> without completing the command, leaving SYNCHRONIZE_CACHE pending until
> the 60s SCSI timeout and triggering the 25s DPM watchdog.
> 
> Track each command's active sense_urb in uas_cmd_info. When a status URB
> fails in uas_stat_cmplt() while not resetting, complete the command that
> owns the failed status URB (with DID_NO_CONNECT on -ENODEV/-ESHUTDOWN
> and DID_ERROR otherwise), free unsubmitted URBs, and unlink any inflight
> data URBs outside devinfo->lock. Set DID_NO_CONNECT on -ENODEV/-ESHUTDOWN
> and preserve non-DID_OK host bytes in uas_data_cmplt().
> 
> Fixes: 115bb1ffa54c ("USB: Add UAS driver")
> Signed-off-by: Sarthak Kukreti <sarthakkukreti@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113024922.27977-1-sarthakkukreti@google.com?part=1