Re: [PATCH v2 1/4] usb: musb: cancel the delayed works after quiescing the interrupt

[sashiko-bot@kernel.org]

> musb_remove() cancels finish_resume_work and deassert_reset_work up
> front, while the interrupt is still enabled and the root hub is still
> registered, and cancels irq_work only later.  All three works can be
> armed past their cancel:
> 
> - musb_handle_intr_resume() schedules finish_resume_work from
>   interrupt context (RESUME in OTG_STATE_A_SUSPEND, via
>   musb_stage0_irq());
> - musb_hub_control() schedules finish_resume_work (ClearPortFeature
>   SUSPEND -> musb_port_suspend()) and deassert_reset_work
>   (SetPortFeature RESET -> musb_port_reset()) from process context,
>   and the root hub is only torn down by musb_host_cleanup();
> - musb_stage0_irq() schedules irq_work, which can also re-arm itself
>   from the session recheck path (musb_pm_runtime_check_session()).
> 
> [ ... ]
> 
> Suggested-by: Neill Kapron <nkapron@google.com>
> Fixes: f730f205cc51 ("usb: musb: Split PM runtime between wrapper IP and musb core")
> Cc: stable@vger.kernel.org
> Signed-off-by: Chengyu Liu <lui2012qwq@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113063409.47485-1-lui2012qwq@gmail.com?part=1