Re: [PATCH 3/8] usb: typec: fusb302: Switch to device managed resources

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] usb: typec: fusb302: build failure when CONFIG_DEBUG_FS is
  disabled
--

commit a5e9f3a79e68305810f439c482d64544f3449258
Author: Sebastian Reichel <sebastian.reichel@collabora.com>

usb: typec: fusb302: Switch to device managed resources

This commit converts fusb302_probe() and fusb302_remove() to use
device-managed resources for mutexes, workqueues, debugfs, fwnode, TCPM
port registration, work items, and interrupts.

> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 83bd287dadc7e..a7a1dce6cf86a 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
[ ... ]
> @@ -210,20 +211,28 @@ static int fusb302_debug_show(struct seq_file *s, void *v)
>  }
>  DEFINE_SHOW_ATTRIBUTE(fusb302_debug);
>  
> -static void fusb302_debugfs_init(struct fusb302_chip *chip)
> +static void fusb302_debugfs_exit(void *data)
> +{
> +	struct fusb302_chip *chip = data;
> +
> +	debugfs_remove(chip->dentry);
> +}
> +
> +static int fusb302_debugfs_init(struct fusb302_chip *chip)
>  {
>  	char name[NAME_MAX];
> +	int ret;
> +
> +	ret = devm_mutex_init(chip->dev, &chip->logbuffer_lock);
> +	if (ret < 0)
> +		return ret;
>  
> -	mutex_init(&chip->logbuffer_lock);
>  	snprintf(name, NAME_MAX, "fusb302-%s", dev_name(chip->dev));
>  	chip->dentry = debugfs_create_dir(name, usb_debug_root);
>  	debugfs_create_file("log", S_IFREG | 0444, chip->dentry, chip,
>  			    &fusb302_debug_fops);
> -}
>  
> -static void fusb302_debugfs_exit(struct fusb302_chip *chip)
> -{
> -	debugfs_remove(chip->dentry);
> +	return devm_add_action_or_reset(chip->dev, fusb302_debugfs_exit, chip);
>  }
>  
>  #else
>  
>  static void fusb302_log(const struct fusb302_chip *chip,
>  			const char *fmt, ...) { }
>  static void fusb302_debugfs_init(const struct fusb302_chip *chip) { }
> -static void fusb302_debugfs_exit(const struct fusb302_chip *chip) { }
>  
>  #endif

[Severity: High]
Does the !CONFIG_DEBUG_FS stub for fusb302_debugfs_init() also need to
return int (0)?  fusb302_probe() now assigns its return value to ret,
which fails to build when CONFIG_DEBUG_FS is disabled.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-fusb302-probe-cleanup-v1-0-e5c65a8c58c8@collabora.com?part=3