Re: [PATCH net-next v21 11/13] ax88179_178a: Update driver name and information

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] net: usb: ax88179: Kconfig rename drops default y and
  disables driver
--

commit a2dd9912da623ded3490ea8a07a91779c220769c
Author: Birger Koblitz <mail@birger-koblitz.de>

ax88179_178a: Update driver name and information

This commit renames Kconfig symbol USB_NET_AX88179_178A to USB_NET_AX88179,
updates the USB driver name to "ax88179", and expands the Kconfig and
module descriptions for newly supported ASIX chips.

> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 115990b0d9537..cc8f2e1503399 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -195,18 +195,21 @@ config USB_NET_AX8817X
>  	  This driver creates an interface named "ethX", where X depends on
>  	  what other networking devices you have in use.
>  
> -config USB_NET_AX88179_178A
> -	tristate "ASIX AX88179/178A USB 3.0/2.0 to Gigabit Ethernet"
> +config USB_NET_AX88179
> +	tristate "ASIX AX88179/179A/178A USB 2.0/3.0 to 100M/1G/2.5GbE Adapters"
>  	depends on USB_USBNET
> -	select CRC32
>  	select PHYLINK
> -	default y
> +	select AX88796B_PHY
> +	select CRC32

[Severity: Medium]
Does dropping "default y" when renaming USB_NET_AX88179_178A to
USB_NET_AX88179 disable this driver across existing configurations?

Because savedefconfig omits symbols that match their default, the 25 in-tree
defconfigs that enable CONFIG_USB_USBNET relied on "default y" to build this
driver and did not list CONFIG_USB_NET_AX88179_178A explicitly.  Removing
"default y" alongside the symbol rename causes a regression where
CONFIG_USB_NET_AX88179 defaults to n, disabling the driver in those
defconfigs and when updating existing .config files via olddefconfig, while
also making the "# CONFIG_USB_NET_AX88179 is not set" overrides in
loongson32_defconfig and loongson64_defconfig redundant.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114-ax88179a-v21-0-c2d34410bcbe@birger-koblitz.de?part=11