From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794774485; b=dNbBp/JqjtYTX1X9/rXtLBGrCdREHKsNZvvcjogiJR68jENngjbSaaGnzKoe03qafCdZ efEpn1CUkPCJJS31X4HLZ4qf2zaAVXJo8f4Vg40l8bOHZDmzprXWt7yopr88VCez/hwOd yTQYrkTeJwGLQGyWtNZVRTYO/7f1MnWagnYtTlgUFy7G+BuE/6RkdfiEJTV4gova68pqE +8c5Pq+DQy8nQtLNUx5l3wX+4k5+jgIKZO2WNfKHRBlKt0TKgSodUfyzcdAhIgnGnLSNz ru3Iq/Y/LxgZni8Kw8dJpu935dN35wclVVHXezC/DYcWsOax5NkCjDIBLmS3Qtv8q0g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794774485; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=iL9gs0hHi938yh2WI7Rig0yplwSjqvzkRGjQ5uPboKU=; b=FU216ENVWaqGMGvhcPG1VDyO6SZ4qqwtEprPU/0lQ5S7LG3I8nJQQlFujFvXSaU+sRi5 koCbJ5uS1lsi/9k+XC2shyhBvX10DZgHLMDaLIPOwS3clM91jxeTNSzSkn4vD+u9i/fKU LF5Ia9r/bqHWIs3vJnDFh3tqpcfVThjTkC4JFCbDCxRijIv50OlRsoAxYiolstX3opBRI WsFma+tv/VPNpMhI45zNiNJHL38tDnS90KUDitvCbuOWejs+Ye9KRePaSCRNpp54hL+/E NhjIoqRIdxBTnActP194oUOtV82vPg4JRwA6QA8QKgETFw38u534CQJMcpQOQrXq7bQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ETF5Z0WA; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3818F606A336; Sun, 15 Nov 2026 20:28:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ETF5Z0WA Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3DCB1F000C4; Sun, 15 Nov 2026 20:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794774484; bh=iL9gs0hHi938yh2WI7Rig0yplwSjqvzkRGjQ5uPboKU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ETF5Z0WAqh95BGpkVJKfpqGcs9JI8RAoRt4nI+73Jvpwec+3LLtpvx5oLIOpOfGsT GOEPDW9rPmVNyvWKj75N4qe/uuqYO9Ct+c+rkqTJy8JuSRXz8Cd8ame+5r1JLvG/3A reDElin5T7+X5Y7q3072wbnRv3MkRD1vWKJ66eWwdYKSqePxhpqdkT13QWNUnnpmGY uWWkItczjTLp6aObld3Ovht8ffOQ/ZvRuyPp7S9k0+Fw6T0VXIdNJKdR58ItUCYtae UkRrFmwjS4VMsil7spiRSB/64XxcHyS+/KBT36lH7fuE9R+NdOThy0hIAK8YBBEQQ1 KRVyv4dQidmtA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 10/12] docs: ioctl-number: update FS entries Reply-To: sashiko-reviews@lists.linux.dev To: "Randy Dunlap" Cc: "Jonathan Corbet" , "Shuah Khan" , "David Hildenbrand" , "Andrew Morton" , "Jason Gunthorpe" , "Leon Romanovsky" , linux-mm@kvack.org, "Jaroslav Kysela" , "Takashi Iwai" , linux-sound@vger.kernel.org, "Jens Axboe" , "Marcel Holtmann" , "Luiz Augusto von Dentz" , "Willem de Bruijn" , "Jason Wang" , "David Heidelberg" , "Chas Williams" <3chas3@gmail.com>, "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Helge Deller" , dri-devel@lists.freedesktop.org, MPT-FusionLinux.pdl@broadcom.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, "Miquel Raynal" , "Richard Weinberger" , "Vignesh Raghavendra" , "Zhihao Cheng" , linux-mtd@lists.infradead.org, "Neill Kapron" , "Andrey Konovalov" , "Greg Kroah-Hartman" , linux-usb@vger.kernel.org, "Juergen Gross" , "Stefano Stabellini" , "Hans de Goede" , "Arnd Bergmann" , "Michael S. Tsirkin" , =?utf-8?b?RXVnZW5pbyBQw6lyZXo=?= , "Sean Christopherson" , "Paolo Bonzini" , kvm@vger.kernel.org, virtualization@lists.linux.dev, "Jan Kara" , =?utf-8?b?VGhlb2RvcmUgVHMnbw==?= , linux-ext4@vger.kernel.org, "Mike Marshall" , devel@lists.orangefs.org, "Paulo Alcantara" , "Namjae Jeon" , "Jaegeuk Kim" , "Chao Yu" , "Florian Fainelli" , "Broadcom internal kernel review list" , "Tzung-Bi Shih" , "Benson Leung" , "David Airlie" , "Simona Vetter" , "Alex Deucher" , =?utf-8?b?Q2hyaXN0aWFuIEvDtm5pZw==?= , amd-gfx@lists.freedesktop.org, "Jani Nikula" , "Joonas Lahtinen" , "Rodrigo Vivi" , "Tvrtko Ursulin" , intel-gfx@lists.freedesktop.org, "Matthew Brost" , =?utf-8?b?VGhvbWFzIEhlbGxzdHLDtm0=?= , intel-xe@lists.freedesktop.org In-Reply-To: <20261114202653.3113381-11-rdunlap@infradead.org> References: <20261114202653.3113381-1-rdunlap@infradead.org> <20261114202653.3113381-11-rdunlap@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 15 Nov 2026 20:27:54 +0000 X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] docs: ioctl-number: ext4 00-2F ioctl range points to fs/ext4/ext4.h instead of uapi/linux/ext4.h -- commit 9072a8199d2be085dc5ab2567392180faf810c6d Author: Randy Dunlap docs: ioctl-number: update FS entries This commit updates the header file paths and sequence number ranges for filesystem ioctls in Documentation/userspace-api/ioctl/ioctl-number.rst. > diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documen= tation/userspace-api/ioctl/ioctl-number.rst > index 87e547be9e2ac..abc89b6288ba3 100644 > --- a/Documentation/userspace-api/ioctl/ioctl-number.rst > +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst [ ... ] > @@ -275,7 +276,7 @@ Code Seq# Include File = Comments > 'f' 00-1F linux/ext2_fs.h c= onflict! > 'f' 00-1F linux/ext3_fs.h c= onflict! > 'f' 00-0F fs/jfs/jfs_dinode.h c= onflict! > -'f' 00-0F fs/ext4/ext4.h c= onflict! > +'f' 00-2F fs/ext4/ext4.h c= onflict! [Severity: Low] Should this entry point to uapi/linux/ext4.h (or both headers) instead of only fs/ext4/ext4.h? Commit 519fe1bae7e2 ("ext4: Add a uapi header for ext4 userspace APIs") moved the EXT4_IOC_* definitions spanning 0x03 through 0x2E into include/uapi/linux/ext4.h, leaving only the compat EXT4_IOC32_* definitions (0x03 through 0x08) in fs/ext4/ext4.h. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261114202653.3113= 381-1-rdunlap@infradead.org?part=3D10