From: sashiko-bot@kernel.org
To: "Gichoon Han" <gichoon.han@samsung.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: host: ehci-sched: Don't let a bogus siTD remaining length underflow
Date: Mon, 16 Nov 2026 05:38:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-216218@kernel.org> (raw)
In-Reply-To: <20261116052851.2272125-1-gichoon.han@samsung.com>
> sitd_complete() computes the received length of a split isochronous
> packet as desc->length - SITD_LENGTH(t), where SITD_LENGTH() is the
> "Total Bytes to Transfer" count the controller leaves in the siTD.
> Nothing checks that this remaining count is not larger than what was
> programmed. If the controller reports a larger value, the unsigned
> subtraction wraps and the class driver gets an actual_length of
> nearly 4 GiB for a packet that can hold at most 1023 bytes.
>
> This was seen on an ARM32 system (vendor 5.4 kernel; this code is
> unchanged in mainline) with a full-speed UAC1 microphone behind a
> high-speed hub. snd-usb-audio trusted the value and read far past
> the URB transfer buffer:
>
> Unable to handle kernel paging request at virtual address e8756000
> Internal error: Oops: 7 [#1] PREEMPT SMP ARM
> [ ... ]
>
> Link: https://lore.kernel.org/r/87se19ufoi.wl-tiwai@suse.de
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gichoon Han <gichoon.han@samsung.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116052851.2272125-1-gichoon.han@samsung.com?part=1
prev parent reply other threads:[~2026-11-16 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20261116052855epcas1p403c518b90d70d98752ad0ca2d9ac05e9@epcas1p4.samsung.com>
2026-11-16 5:28 ` [PATCH] usb: host: ehci-sched: Don't let a bogus siTD remaining length underflow Gichoon Han
2026-11-16 5:38 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216218@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=gichoon.han@samsung.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox