Linux USB
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Andrew Gaylard" <ag@ffroot.co.za>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] phy: sunplus: free the disc_vol buffer in update_disc_vol()
Date: Mon, 16 Nov 2026 07:46:11 +0000	[thread overview]
Message-ID: <sashiko-outbox-216462@kernel.org> (raw)
In-Reply-To: <20261116074006.20357-2-ag@ffroot.co.za>

> nvmem_cell_read() returns a buffer that the caller must free.
> update_disc_vol() never frees it, so every PHY initialisation leaks
> it: at boot, and again each time the EHCI or OHCI driver is unbound
> and bound.
> 
> Free the buffer after taking the disconnect-voltage level from it.
> 
> Tested on a Tibbo LTPP3G2 board.
> 
> Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021")
> Signed-off-by: Andrew Gaylard <ag@ffroot.co.za>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116074006.20357-1-ag@ffroot.co.za?part=2


  reply	other threads:[~2026-11-16  7:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:40 [PATCH 1/2] phy: sunplus: don't read the disc_vol cell after nvmem_cell_get() fails Andrew Gaylard
2026-11-16  7:40 ` [PATCH 2/2] phy: sunplus: free the disc_vol buffer in update_disc_vol() Andrew Gaylard
2026-11-16  7:46   ` sashiko-bot [this message]
2026-11-16  7:49 ` [PATCH 1/2] phy: sunplus: don't read the disc_vol cell after nvmem_cell_get() fails sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216462@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=ag@ffroot.co.za \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox