Linux USB
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Selvarasu Ganesan" <selvarasu.g@samsung.com>, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: core: don't skip system resume for an already suspended device
Date: Mon, 16 Nov 2026 13:13:40 +0000	[thread overview]
Message-ID: <sashiko-outbox-217053@kernel.org> (raw)
In-Reply-To: <973576304.21794834003625.JavaMail.epsvc@epcpadp1new>

> When offload is active on a USB device, usb_suspend_both() skips
> suspending it during system suspend so that the port is not pushed
> into its deep low power state.
> 
> The commit bd3d245b0fef ("usb: core: use dedicated spinlock for offload
> state") made the resume path skip resuming the device whenever offload
> is active at resume time, instead of only when the corresponding suspend
> was skipped. That is wrong when the device was already suspended:
> 
>   1. Streaming is running with offload active and the AP side stops
>      using the device, the user pauses streaming, or the USB interface
>      simply becomes idle.
>   2. The device auto-suspends.  The auto-suspend path
>      (PMSG_AUTO_SUSPEND) does not carry the PM_EVENT_SUSPEND event, so
>      the offload state is not consulted.  The port goes into its deep
> [ ... ]
> normal resume, as before bd3d245b0fef.
> 
> Fixes: bd3d245b0fef ("usb: core: use dedicated spinlock for offload state")
> Cc: stable@vger.kernel.org
> Signed-off-by: Selvarasu Ganesan <selvarasu.g@samsung.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/973576304.21794834003625.JavaMail.epsvc@epcpadp1new?part=1


      reply	other threads:[~2026-11-16 13:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20261116125643epcas5p17e73b0fa50f1cb7609b1d90d62c5e3f6@epcas5p1.samsung.com>
2026-11-16 12:56 ` [PATCH] usb: core: don't skip system resume for an already suspended device Selvarasu Ganesan
2026-11-16 13:13   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217053@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=selvarasu.g@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox