Linux USB
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yingjie Wang" <x-professor@outlook.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2] usb: gadget: midi2: copy configfs strings for live functions
Date: Tue, 17 Nov 2026 03:37:57 +0000	[thread overview]
Message-ID: <sashiko-outbox-218145@kernel.org> (raw)
In-Reply-To: <279d2387232d774116d674f718f381438abc90fe.1794886308.git.x-professor@outlook.com>

> f_midi2_alloc() shallow-copies the card, endpoint, and block string
> pointers from configfs.  Dynamic ep.* and block.* groups may be removed
> after the function has been allocated.  Their release callbacks then free
> strings still used by live USB string descriptors and UMP discovery
> replies.
> 
> Copy the optional strings while opts->lock is held, so configfs release
> cannot free the source strings during the copy.  Free the private copies
> with the live function and build the USB string table from those copies.
> 
> On x86_64 with KASAN and dummy_hcd, USB string descriptor requests made
> after removing a dynamic block and endpoint trigger two
> slab-use-after-free reports on the unpatched kernel. With this change,
> the same requests complete without a KASAN report.
> 
> Fixes: 29ee7a4dddd5 ("usb: gadget: midi2: Add configfs support")
> Cc: stable@vger.kernel.org
> Reviewed-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Yingjie Wang <x-professor@outlook.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/279d2387232d774116d674f718f381438abc90fe.1794886308.git.x-professor@outlook.com?part=1


      reply	other threads:[~2026-11-17  3:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  3:31 [PATCH v2] usb: gadget: midi2: copy configfs strings for live functions Yingjie Wang
2026-11-17  3:37 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218145@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=x-professor@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox