From: sashiko-bot@kernel.org
To: "Linus Walleij" <linusw@kernel.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: pxa25x_udc: Support combined PXA and IXP4xx builds
Date: Tue, 17 Nov 2026 10:57:06 +0000 [thread overview]
Message-ID: <sashiko-outbox-218680@kernel.org> (raw)
In-Reply-To: <20261117-usb-pxa25x-udc-v1-1-fdfcec62d336@kernel.org>
> Allowing little-endian IXP4xx kernels makes it possible to enable both
> ARCH_IXP4XX and ARCH_PXA. The shared UDC driver still assumes that these
> platforms are mutually exclusive: it defines UDCCS_IO_ROF twice and stops
> the build with "Can't configure both IXP and PXA".
>
> Select the controller quirks using the running CPU rather than the kernel
> configuration. Match both XScale CPU families and their supported
> revisions, and remember whether the controller belongs to IXP4xx. Use that
> flag to select the existing isochronous receive overflow bit and to keep
> the EP0 status workaround specific to PXA.
>
> Remove the IXP4xx clock API overrides so that PXA clock control still
> works in a combined kernel. Leave the clock NULL on IXP4xx, which has no
> software-controlled UDC clock, and rely on the clock API's NULL handling.
>
> Fixes: 2262f02ac2aa ("ARM: ixp4xx: Relax endianness")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202611082010.e3nJgvr4-lkp@intel.com/
> Signed-off-by: Linus Walleij <linusw@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-usb-pxa25x-udc-v1-1-fdfcec62d336@kernel.org?part=1
prev parent reply other threads:[~2026-11-17 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 10:47 [PATCH] usb: gadget: pxa25x_udc: Support combined PXA and IXP4xx builds Linus Walleij
2026-11-17 10:57 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218680@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox