Linux USB
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Radhey Shyam Pandey" <radhey.shyam.pandey@amd.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 4/4] usb: dwc3: xilinx: Add support to program MMI USB TX deemphasis
Date: Tue, 17 Nov 2026 16:00:17 +0000	[thread overview]
Message-ID: <sashiko-outbox-219124@kernel.org> (raw)
In-Reply-To: <20261117150219.1326693-5-radhey.shyam.pandey@amd.com>

> Introduces support for programming the 18-bit TX deemphasis value that
> drives the pipe_TxDeemph signal, as defined in the PIPE4 specification.
> 
> The value is supplied by the glue driver through struct dwc3_properties,
> which the flat model provides for core properties the glue knows at probe
> time, and is programmed into LCSR_TX_DEEMPH during SoC bus configuration.
> 
> The configured value is recommended by Synopsys and is intended for
> standard (non-compliance) operation. These Gen2 equalization settings
> have been validated through both internal and external compliance
> testing. By applying this setting, the stability of USB 3.2 enumeration
> is improved and now SuperSpeedPlus devices are consistently recognized as
> USB 3.2 Gen2 by the MMI USB Host controller.
> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117150219.1326693-1-radhey.shyam.pandey@amd.com?part=4


      reply	other threads:[~2026-11-17 16:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 15:02 [PATCH v5 0/4] usb: dwc3: xilinx: Add Versal2 MMI USB 3.2 controller support Radhey Shyam Pandey
2026-11-17 15:02 ` [PATCH v5 1/4] usb: dwc3: xilinx: use device_get_match_data() in probe Radhey Shyam Pandey
2026-11-17 15:18   ` sashiko-bot
2026-11-17 15:02 ` [PATCH v5 2/4] dt-bindings: usb: amd,versal2-mmi-dwc3: Add MMI USB support on Versal Gen2 platform Radhey Shyam Pandey
2026-11-17 15:20   ` sashiko-bot
2026-11-17 15:02 ` [PATCH v5 3/4] usb: dwc3: xilinx: Add Versal2 MMI USB 3.2 controller support with flat probe model Radhey Shyam Pandey
2026-11-17 15:55   ` sashiko-bot
2026-11-17 15:02 ` [PATCH v5 4/4] usb: dwc3: xilinx: Add support to program MMI USB TX deemphasis Radhey Shyam Pandey
2026-11-17 16:00   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219124@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=radhey.shyam.pandey@amd.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox