Linux USB
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yehyeong Lee" <yhlee@isslab.korea.ac.kr>, linux-usb@vger.kernel.org
Subject: Re: [PATCH v8 3/4] usb: gadget: f_tcm: reject a short write data-out transfer
Date: Wed, 18 Nov 2026 12:59:53 +0000	[thread overview]
Message-ID: <sashiko-outbox-220955@kernel.org> (raw)
In-Reply-To: <20261118124005.2428068-4-yhlee@isslab.korea.ac.kr>

> usbg_data_write_cmpl() copies se_cmd->data_length bytes out of the bounce
> buffer into the command's scatter-gather list without checking how much the
> host actually sent.  A BOT host can declare a larger OUT transfer than it
> delivers and end the data stage with a short packet: req->actual is then
> shorter than req->length, but the completion handler still commits the full
> declared length.  The tail past req->actual is whatever was already in the
> kmalloc'd bounce buffer, which is not zeroed, so bytes the host never sent
> are written to the backing store and can be read back by the host.
> 
> Fail the command when req->actual does not match req->length instead of
> committing that tail.  By the time usbg_data_write_cmpl() runs the OUT
> data request has completed, so mark the command and skip the ep_out drain
> in bot_send_bad_status() - there is nothing left on the wire, and draining
> it re-arms ep_out for data the host already finished sending and wedges the
> bulk pipe.  This mirrors how f_mass_storage stops draining once the host
> ends the OUT stage.  A command rejected before its data stage still drains,
> since the host has yet to send it.
> 
> On a dummy_hcd gadget, a WRITE(10) declaring 8192 bytes whose data stage
> delivers 4000 and ends on a short packet is answered with a CSW status of
> 0, and reading the range back shows the 4000 bytes the host sent followed
> by 4192 bytes it did not.  With this patch the command fails, the CSW
> status is 1, and the range reads back unchanged.
> 
> Fixes: c52661d60f63 ("usb-gadget: Initial merge of target module for UASP + BOT")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yehyeong Lee <yhlee@isslab.korea.ac.kr>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118124005.2428068-1-yhlee@isslab.korea.ac.kr?part=3


  reply	other threads:[~2026-11-18 12:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 12:40 [PATCH v8 0/4] usb: gadget: f_tcm: fix infoleaks, sleep, and UAF in the BOT path Yehyeong Lee
2026-11-18 12:40 ` [PATCH v8 1/4] usb: gadget: f_tcm: queue the BOT status requests with GFP_ATOMIC Yehyeong Lee
2026-11-18 12:43   ` sashiko-bot
2026-11-18 12:40 ` [PATCH v8 2/4] usb: gadget: f_tcm: zero the CBW buffer the status path sends Yehyeong Lee
2026-11-18 12:45   ` sashiko-bot
2026-11-18 12:40 ` [PATCH v8 3/4] usb: gadget: f_tcm: reject a short write data-out transfer Yehyeong Lee
2026-11-18 12:59   ` sashiko-bot [this message]
2026-11-18 12:40 ` [PATCH v8 4/4] usb: gadget: f_tcm: clear the scatter list when reusing the BOT status request Yehyeong Lee
2026-11-18 12:46   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220955@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yhlee@isslab.korea.ac.kr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox