Linux USB
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Guangshuo Li" <liguangshuo@mail.sdu.edu.cn>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: gadget: nokia: Fix potential use-after-free on bind failure
Date: Wed, 18 Nov 2026 14:28:44 +0000	[thread overview]
Message-ID: <sashiko-outbox-221205@kernel.org> (raw)
In-Reply-To: <20261118-324f82bd41-usb-gadget-2@mail.sdu.edu.cn>

> If the second configuration fails to bind, nokia_bind() frees the
> functions in the first configuration while they remain on its function
> list. Composite cleanup then accesses the freed functions.
> 
> Remove those functions before putting them, and also put the mass-storage
> function acquired for the first configuration.
> 
> This issue was found by our static analysis tool under development.
> 
> Fixes: 15761826eecd ("usb: gadget: nokia: use function framework for ACM")
> Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-324f82bd41-usb-gadget-0@mail.sdu.edu.cn?part=2


      reply	other threads:[~2026-11-18 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 14:08 [PATCH 0/2] usb: gadget: Correct cleanup ordering on failure and removal Guangshuo Li
2026-11-18 14:10 ` [PATCH 1/2] usb: gadget: fsl_udc: Fix potential use-after-free during removal Guangshuo Li
2026-11-18 14:29   ` sashiko-bot
2026-11-18 14:13 ` [PATCH 2/2] usb: gadget: nokia: Fix potential use-after-free on bind failure Guangshuo Li
2026-11-18 14:28   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221205@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=liguangshuo@mail.sdu.edu.cn \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox