Linux USB
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Oleh Kurudz" <admin@or1k.net>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] USB: core: Add USB_QUIRK_DISCONNECT_PARENT_SUSPEND
Date: Thu, 19 Nov 2026 22:30:31 +0000	[thread overview]
Message-ID: <sashiko-outbox-224133@kernel.org> (raw)
In-Reply-To: <20261120-quadcast-s-suspend-v1-1-add8ccf12c8f@or1k.net>

> From: Oleh Kurudz <admin@or1k.net>
> 
> Some USB products are several functions behind a small hub inside the
> same enclosure. On the HyperX QuadCast S microphone one of these
> functions drops off the bus while the system is suspending, and the
> built-in hub then reports the connect change upstream and wakes the
> system, even though remote wakeup is disabled for the hub and for
> everything behind it. On s2idle systems the suspend bounces back within
> about a second.
> 
> USB_QUIRK_DISCONNECT_SUSPEND does not help here. Set on the function
> that drops off, it disables that function's port on the built-in hub,
> but the hub itself still signals the wakeup. Set on the hub, it would
> affect every product that uses the same generic hub chip (a Huasheng
> 214b:7250 in this case), including ones with a keyboard behind it that
> [ ... ]
> This patch and its changelog were written with the help of an AI
> coding assistant (Claude, claude-opus-5-5). I reviewed the result and
> tested it on my hardware, see the next patch.
> 
> Signed-off-by: Oleh Kurudz <admin@or1k.net>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-quadcast-s-suspend-v1-0-add8ccf12c8f@or1k.net?part=1


  reply	other threads:[~2026-11-19 22:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 22:22 [PATCH 0/2] USB: core: Disconnect a parent hub on suspend for HyperX QuadCast S Oleh Kurudz via B4 Relay
2026-11-19 22:22 ` [PATCH 1/2] USB: core: Add USB_QUIRK_DISCONNECT_PARENT_SUSPEND Oleh Kurudz via B4 Relay
2026-11-19 22:30   ` sashiko-bot [this message]
2026-11-19 22:22 ` [PATCH 2/2] USB: quirks: Add USB_QUIRK_DISCONNECT_PARENT_SUSPEND for HyperX QuadCast S Oleh Kurudz via B4 Relay
2026-11-19 22:27   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224133@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=admin@or1k.net \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox