Linux USB
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Neil Armstrong" <neil.armstrong@linaro.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: typec: qcom-pmic-typec: pdphy: disable the PD PHY on stop
Date: Fri, 20 Nov 2026 10:03:39 +0000	[thread overview]
Message-ID: <sashiko-outbox-224903@kernel.org> (raw)
In-Reply-To: <20261120-topic-tcpm-qcom-fixes-v1-1-9a152f906fba@linaro.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] usb: typec: qcom-pmic-typec: missing Fixes trailer for pdphy
  stop fix
--

commit b45aad2ca233d0a40118f71870955c8a4770e204
Author: Neil Armstrong <neil.armstrong@linaro.org>

> usb: typec: qcom-pmic-typec: pdphy: disable the PD PHY on stop
>
> qcom_pmic_typec_pdphy_stop() only terminates the ongoing transmission and
> clears the RX frame filter, the PD PHY itself stays enabled.
>
> Use qcom_pmic_typec_pdphy_disable() so the PD PHY is also turned off
> before its supply is released, leaving it in the same state as before
> qcom_pmic_typec_pdphy_start().
>
> Assisted-by: LLM
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

[Severity: Low]
This fixes qcom_pmic_typec_pdphy_stop() leaving the PD PHY enabled when stopping.  Should this include:

  Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-topic-tcpm-qcom-fixes-v1-0-9a152f906fba@linaro.org?part=1

  reply	other threads:[~2026-11-20 10:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  9:59 [PATCH 0/2] usb: typec: qcom-pmic-typec: properly tear down port on remove and shutdown Neil Armstrong
2026-11-20  9:59 ` [PATCH 1/2] usb: typec: qcom-pmic-typec: pdphy: disable the PD PHY on stop Neil Armstrong
2026-11-20 10:03   ` sashiko-bot [this message]
2026-11-20  9:59 ` [PATCH 2/2] usb: typec: qcom-pmic-typec: detach the port on shutdown Neil Armstrong
2026-11-20 10:15   ` sashiko-bot
2026-11-20 10:53     ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224903@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox