From: sashiko-bot@kernel.org
To: "Max Andreev" <drunkbatya.js@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: fix missed frs_sourcing_vbus() call during FRS
Date: Sun, 22 Nov 2026 10:36:45 +0000 [thread overview]
Message-ID: <sashiko-outbox-227895@kernel.org> (raw)
In-Reply-To: <20261122102839.2902079-1-drunkbatya.js@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] usb: typec: tcpm: Signed-off-by and Fixes trailers placed below
--- tearline
--
commit 2b51cba8ef01ebefb9093ae6c74c438910efa79e
Author: Max Andreev <drunkbatya.js@gmail.com>
> usb: typec: tcpm: fix missed frs_sourcing_vbus() call during FRS
>
> Since commit 0908c5aca31e ("usb: typec: tcpm: AMS and Collision
> Avoidance") the TCPC reports sourcing vbus while the port is still in
> AMS_START with FR_SWAP_SEND as the upcoming state. Because of
> _tcpm_pd_vbus_on() ignores this state, frs_sourcing_vbus() is never called
> during FRS.
>
> On Pixel 11 Pro XL after an FRS from sink to source the phone keeps
> showing the charging indicator, and about 20 seconds later VBUS drops
> and the attached device reboots.
>
> Call frs_sourcing_vbus() from AMS_START when the upcoming state is
> FR_SWAP_SEND.
[Severity: High]
The Fixes:, Cc:, and Signed-off-by: trailers were placed below the first
"---" separator line in the patch, causing git am to strip them along with
the patch commentary and leaving the applied commit without a
Signed-off-by: or Fixes: trailer. Those trailers need to sit above the
first "---" line so they are kept in the commit message.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261122102839.2902079-1-drunkbatya.js@gmail.com?part=1
next prev parent reply other threads:[~2026-11-22 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 10:28 [PATCH] usb: typec: tcpm: fix missed frs_sourcing_vbus() call during FRS Max Andreev
2026-11-22 10:36 ` sashiko-bot [this message]
2026-11-22 10:38 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227895@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=drunkbatya.js@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox