Linux USB
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sasha Levin" <sashal@kernel.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] phy: qcom: uniphy-pcie-28lp: Rename the PHY type enum values
Date: Sun, 22 Nov 2026 15:30:47 +0000	[thread overview]
Message-ID: <sashiko-outbox-228042@kernel.org> (raw)
In-Reply-To: <20261122152857.1113943-1-sashal@kernel.org>

> Commit b28eecc89399 ("include: linux: phy: Add phy attribute "type" and
> associated helpers") makes <linux/phy/phy.h> include <dt-bindings/phy/phy.h>,
> which defines PHY_TYPE_PCIE. That clashes with the driver's own enum, and the
> build fails:
> 
>   include/dt-bindings/phy/phy.h:15:33: error: expected identifier before numeric constant
>   drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c:127:27: error: 'PHY_TYPE_PCIE_GEN2' undeclared here (not in a function); did you mean 'PHY_TYPE_PCIE'?
>   drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c:135:27: error: 'PHY_TYPE_PCIE_GEN3' undeclared here (not in a function); did you mean 'PHY_TYPE_PCIE'?
> 
> Give the enum values a QCOM_UNIPHY_ prefix.
> 
> Fixes: b28eecc89399 ("include: linux: phy: Add phy attribute "type" and associated helpers")
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122152857.1113943-1-sashal@kernel.org?part=1

      reply	other threads:[~2026-11-22 15:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22 15:28 [PATCH] phy: qcom: uniphy-pcie-28lp: Rename the PHY type enum values Sasha Levin
2026-11-22 15:30 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-228042@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox