From: Zhaoyang Yu <2426767509@qq.com>
To: sergei.shtylyov@gmail.com, daniel@zonque.org,
haojian.zhuang@gmail.com, robert.jarzmik@free.fr,
gregkh@linuxfoundation.org
Cc: linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Zhaoyang Yu <2426767509@qq.com>
Subject: [PATCH] USB: pxa27x_udc: check return value of clk_enable
Date: Sun, 1 Mar 2026 16:55:53 +0000 [thread overview]
Message-ID: <tencent_358DF7F3BD49A6407C17B7B26307A3B0AC0A@qq.com> (raw)
clk_enable() may fail according to the API contract.
Previously, udc_enable() ignored its return value.
This patch checks the return value and logs an error
without continuing initialization if clk_enable fails.
Signed-off-by: Zhaoyang Yu <2426767509@qq.com>
---
drivers/usb/gadget/udc/pxa27x_udc.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
index 897f53601b5b..006d6d0a5f9a 100644
--- a/drivers/usb/gadget/udc/pxa27x_udc.c
+++ b/drivers/usb/gadget/udc/pxa27x_udc.c
@@ -1693,10 +1693,16 @@ static void udc_init_data(struct pxa_udc *dev)
*/
static void udc_enable(struct pxa_udc *udc)
{
+ int ret;
+
if (udc->enabled)
return;
- clk_enable(udc->clk);
+ ret = clk_enable(udc->clk);
+ if (ret) {
+ dev_err(udc->dev, "clk_enable failed: %d\n", ret);
+ return;
+ }
udc_writel(udc, UDCICR0, 0);
udc_writel(udc, UDCICR1, 0);
udc_clear_mask_UDCCR(udc, UDCCR_UDE);
--
2.34.1
next reply other threads:[~2026-03-01 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 16:55 Zhaoyang Yu [this message]
2026-03-11 12:49 ` [PATCH] USB: pxa27x_udc: check return value of clk_enable Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-03-01 16:23 Zhaoyang Yu
2026-03-01 16:37 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_358DF7F3BD49A6407C17B7B26307A3B0AC0A@qq.com \
--to=2426767509@qq.com \
--cc=daniel@zonque.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox