From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Kento.A.Kobayashi@sony.com,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Oliver Neukum <oneukum@suse.com>,
gregkh@linuxfoundation.org,
USB Storage list <usb-storage@lists.one-eyed-alien.net>,
Jacky.Cao@sony.com,
Kernel development list <linux-kernel@vger.kernel.org>,
SCSI development list <linux-scsi@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: usb: uas: fix usb subsystem hang after power off hub port
Date: Mon, 08 Apr 2019 22:10:19 -0400 [thread overview]
Message-ID: <yq1a7h0orn8.fsf@oracle.com> (raw)
Alan,
> So it looks as though the SCSI subsystem doesn't like to have a reset
> handler call scsi_remove_host.
Are you talking about a PCI device removal handler or a SCSI error
handler?
> Commands dispatched by the removal routines are forced to wait for the
> reset recovery to finish, which won't happen until those commands have
> been completed.
>
> Is this a bug in the SCSI core? If not, we need to know what is the
> right way to do things when a reset handler detects that the SCSI host
> has been hot-unplugged.
PCI surprise removal should generally work. But it's somewhat unusual
for a SCSI host to evaporate in the middle of error handling. After all,
the main purpose of eh is to leverage the interfaces provided by the
host to try to reconnect to a target that tripped and fell off the
bus...
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Kento.A.Kobayashi@sony.com,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Oliver Neukum <oneukum@suse.com>, <gregkh@linuxfoundation.org>,
USB Storage list <usb-storage@lists.one-eyed-alien.net>,
<Jacky.Cao@sony.com>,
Kernel development list <linux-kernel@vger.kernel.org>,
SCSI development list <linux-scsi@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: uas: fix usb subsystem hang after power off hub port
Date: Mon, 08 Apr 2019 22:10:19 -0400 [thread overview]
Message-ID: <yq1a7h0orn8.fsf@oracle.com> (raw)
Message-ID: <20190409021019.dmiNGI1arYzdHVh-u7bO3ebGHQI5GXWO_C6IRXHVfU0@z> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1904041522150.1288-100000@iolanthe.rowland.org> (Alan Stern's message of "Thu, 4 Apr 2019 15:33:38 -0400 (EDT)")
Alan,
> So it looks as though the SCSI subsystem doesn't like to have a reset
> handler call scsi_remove_host.
Are you talking about a PCI device removal handler or a SCSI error
handler?
> Commands dispatched by the removal routines are forced to wait for the
> reset recovery to finish, which won't happen until those commands have
> been completed.
>
> Is this a bug in the SCSI core? If not, we need to know what is the
> right way to do things when a reset handler detects that the SCSI host
> has been hot-unplugged.
PCI surprise removal should generally work. But it's somewhat unusual
for a SCSI host to evaporate in the middle of error handling. After all,
the main purpose of eh is to leverage the interfaces provided by the
host to try to reconnect to a target that tripped and fell off the
bus...
--
Martin K. Petersen Oracle Linux Engineering
next prev reply other threads:[~2019-04-09 2:10 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 3:57 usb: uas: fix usb subsystem hang after power off hub port Kento.A.Kobayashi
2019-04-04 19:33 ` Alan Stern
2019-04-09 0:28 ` Kento.A.Kobayashi
2019-04-09 0:28 ` [PATCH] " Kento.A.Kobayashi
2019-04-09 1:21 ` Alan Stern
2019-04-09 1:21 ` [PATCH] " Alan Stern
2019-04-09 2:10 ` Martin K. Petersen [this message]
2019-04-09 2:10 ` Martin K. Petersen
2019-04-09 14:44 ` Alan Stern
2019-04-09 14:44 ` [PATCH] " Alan Stern
2019-04-09 15:16 ` Bart Van Assche
2019-04-09 15:16 ` [PATCH] " Bart Van Assche
2019-04-09 16:45 ` Alan Stern
2019-04-09 16:45 ` [PATCH] " Alan Stern
2019-04-15 0:27 ` Kento.A.Kobayashi
2019-04-15 0:27 ` [PATCH] " Kento.A.Kobayashi
2019-04-15 15:18 ` Alan Stern
2019-04-15 15:18 ` [PATCH] " Alan Stern
2019-04-15 15:32 ` Alan Stern
2019-04-15 15:32 ` [PATCH] " Alan Stern
2019-04-16 2:31 ` Kento.A.Kobayashi
2019-04-16 2:31 ` [PATCH] " Kento.A.Kobayashi
2019-04-10 2:11 ` Martin K. Petersen
2019-04-10 2:11 ` [PATCH] " Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2019-04-02 14:38 Alan Stern
2019-04-02 0:28 Kento.A.Kobayashi
2019-03-29 14:13 Alan Stern
2019-03-28 16:49 Oliver Neukum
2019-03-28 15:57 Alan Stern
2019-03-28 15:15 Oliver Neukum
2019-03-28 7:53 Kento.A.Kobayashi
2019-03-25 10:34 Oliver Neukum
2019-03-25 10:21 Kento.A.Kobayashi
2019-03-15 2:28 Kento.A.Kobayashi
2019-03-12 15:37 Oliver Neukum
2019-03-11 8:36 Kento.A.Kobayashi
2019-03-08 17:33 Alan Stern
2019-03-08 16:52 Oliver Neukum
2019-03-08 9:13 Kento.A.Kobayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1a7h0orn8.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Jacky.Cao@sony.com \
--cc=Kento.A.Kobayashi@sony.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).