From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Bart Van Assche <bvanassche@acm.org>,
"linux-scsi\@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
"usb-storage\@lists.one-eyed-alien.net"
<usb-storage@lists.one-eyed-alien.net>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Justin Piszcz <jpiszcz@lucidpixels.com>
Subject: Re: [PATCH v2] scsi: Fix scsi_get/set_resid() interface
Date: Tue, 05 Nov 2019 23:31:12 -0500 [thread overview]
Message-ID: <yq1bltp39tb.fsf@oracle.com> (raw)
In-Reply-To: <BYAPR04MB58164FF9171FDA66879E7400E77E0@BYAPR04MB5816.namprd04.prod.outlook.com> (Damien Le Moal's message of "Tue, 5 Nov 2019 05:24:04 +0000")
Damien,
> Or keeping resid_len as an unsigned int and adding a flag specifying
> if the value means underflow or overflow ?
It's been broken for so long I'd rather make the overflow case an
opt-in. So a separate flag, please.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-11-06 4:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 9:08 [PATCH v2] scsi: Fix scsi_get/set_resid() interface Damien Le Moal
2019-10-30 15:15 ` Bart Van Assche
2019-10-30 16:21 ` Damien Le Moal
2019-10-30 17:01 ` Bart Van Assche
2019-10-31 8:39 ` Hannes Reinecke
2019-11-05 0:11 ` Damien Le Moal
2019-11-05 5:18 ` Martin K. Petersen
2019-11-05 5:24 ` Damien Le Moal
2019-11-06 4:31 ` Martin K. Petersen [this message]
2019-11-08 16:24 ` Bart Van Assche
2019-11-09 2:36 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1bltp39tb.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Damien.LeMoal@wdc.com \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=jpiszcz@lucidpixels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).