From: "Keiji Hayashibara" <hayashibara.keiji@socionext.com>
To: "Yamada, Masahiro/山田 真弘" <yamada.masahiro@socionext.com>
Cc: wim@iguana.be, "Guenter Roeck" <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
"Masami Hiramatsu" <masami.hiramatsu@linaro.org>,
"Jassi Brar" <jaswinder.singh@linaro.org>,
"Hayashi, Kunihiko/林 邦彦" <hayashi.kunihiko@socionext.com>,
"Owada, Kiyoshi/大和田 清志" <owada.kiyoshi@socionext.com>
Subject: RE: [PATCH V3 2/3] watchdog: uniphier: add UniPhier watchdog driver
Date: Wed, 14 Jun 2017 15:50:37 +0900 [thread overview]
Message-ID: <000101d2e4da$87e7e210$97b7a630$@socionext.com> (raw)
In-Reply-To: <CAK7LNASq9MxUwDrNeRrg_eNkJbXR2J-9hHKGZe6-DtioO3p4cQ@mail.gmail.com>
Hello Yamada-san,
From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]
Sent: Wednesday, June 14, 2017 12:08 PM
>
> 2017-06-13 10:14 GMT+09:00 Keiji Hayashibara
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index 52a70ee..2a9d9a6 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -744,6 +744,17 @@ config ZX2967_WATCHDOG
> > To compile this driver as a module, choose M here: the
> > module will be called zx2967_wdt.
> >
> > +config UNIPHIER_WATCHDOG
> > + tristate "UniPhier watchdog support"
> > + depends on ARCH_UNIPHIER || COMPILE_TEST
>
> This driver relies on syscon_node_to_regmap().
> Could you also add "depends on OF && MFD_SYSCON" ?
OK. I will fix this.
>
>
> > + select WATCHDOG_CORE
> > + help
> > + Say Y here to include support watchdog timer embedded
> > + into the UniPhier system.
> > +
> > + To compile this driver as a module, choose M here: the
> > + module will be called uniphier_wdt.
> > +
----------
Best Regards,
Keiji Hayashibara
next prev parent reply other threads:[~2017-06-14 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 1:14 [PATCH V3 0/3] add UniPhier watchdog support Keiji Hayashibara
2017-06-13 1:14 ` [PATCH V3 1/3] dt-bindings: watchdog: add description for UniPhier WDT controller Keiji Hayashibara
2017-06-13 1:14 ` [PATCH V3 2/3] watchdog: uniphier: add UniPhier watchdog driver Keiji Hayashibara
2017-06-14 3:07 ` Masahiro Yamada
2017-06-14 6:50 ` Keiji Hayashibara [this message]
2017-06-13 1:14 ` [PATCH V3 3/3] arm64: dts: uniphier: add watchdog node for LD11 and LD20 Keiji Hayashibara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101d2e4da$87e7e210$97b7a630$@socionext.com' \
--to=hayashibara.keiji@socionext.com \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=masami.hiramatsu@linaro.org \
--cc=owada.kiyoshi@socionext.com \
--cc=robh+dt@kernel.org \
--cc=wim@iguana.be \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).