From: Randy Dunlap <rdunlap@infradead.org>
To: linux-watchdog@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Cc: Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
Michael Brunner <michael.brunner@kontron.com>
Subject: [PATCH -next] watchdog/kempld_wdt: fix build for COMPILE_TEST
Date: Tue, 28 Feb 2017 10:31:07 -0800 [thread overview]
Message-ID: <00718dc0-2a7c-391d-a091-c79e192dbeb2@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
Fix kconfig dependencies when COMPILE_TEST is enabled so that
interdependent module dependencies are configured as needed.
Fixes build when MFD_KEMPLD=m and KEMPLD_WDT=y and COMPILE_TEST=y.
The problem is in mixing tristate and boolean dependencies.
This fixes 32 build errors like these (most are omitted here):
drivers/built-in.o: In function `kempld_wdt_stop':
kempld_wdt.c:(.text+0x19ab8d): undefined reference to `kempld_get_mutex'
kempld_wdt.c:(.text+0x19ab99): undefined reference to `kempld_read8'
kempld_wdt.c:(.text+0x19abaa): undefined reference to `kempld_write8'
kempld_wdt.c:(.text+0x19abbf): undefined reference to `kempld_release_mutex'
drivers/built-in.o: In function `kempld_wdt_keepalive':
kempld_wdt.c:(.text+0x19ac24): undefined reference to `kempld_release_mutex'
drivers/built-in.o: In function `kempld_wdt_set_stage_action.isra.4':
kempld_wdt.c:(.text+0x19aca1): undefined reference to `kempld_get_mutex'
drivers/built-in.o: In function `kempld_wdt_set_stage_timeout.isra.5':
kempld_wdt.c:(.text+0x19adde): undefined reference to `kempld_release_mutex'
drivers/built-in.o: In function `kempld_wdt_start':
kempld_wdt.c:(.text+0x19ae89): undefined reference to `kempld_get_mutex'
drivers/built-in.o: In function `kempld_wdt_get_timeout.isra.6':
kempld_wdt.c:(.text+0x19b01a): undefined reference to `kempld_read8'
drivers/built-in.o: In function `kempld_wdt_update_timeouts':
kempld_wdt.c:(.text+0x19b0c6): undefined reference to `kempld_get_mutex'
drivers/built-in.o: In function `kempld_wdt_suspend':
kempld_wdt.c:(.text+0x19b136): undefined reference to `kempld_release_mutex'
drivers/built-in.o: In function `kempld_wdt_probe':
kempld_wdt.c:(.text+0x19b1a4): undefined reference to `kempld_get_mutex'
kempld_wdt.c:(.text+0x19b1bd): undefined reference to `kempld_release_mutex'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Michael Brunner <michael.brunner@kontron.com>
---
drivers/watchdog/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20170228.orig/drivers/watchdog/Kconfig
+++ linux-next-20170228/drivers/watchdog/Kconfig
@@ -1063,7 +1063,7 @@ config HP_WATCHDOG
config KEMPLD_WDT
tristate "Kontron COM Watchdog Timer"
- depends on MFD_KEMPLD || COMPILE_TEST
+ depends on MFD_KEMPLD || (MFD_KEMPLD=y && COMPILE_TEST)
select WATCHDOG_CORE
help
Support for the PLD watchdog on some Kontron ETX and COMexpress
next reply other threads:[~2017-02-28 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 18:31 Randy Dunlap [this message]
2017-02-28 18:43 ` [PATCH -next] watchdog/kempld_wdt: fix build for COMPILE_TEST Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00718dc0-2a7c-391d-a091-c79e192dbeb2@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michael.brunner@kontron.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).