From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>,
patrick@stwcx.xyz, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, joel@jms.id.au, wim@linux-watchdog.org,
linux@roeck-us.net, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org
Cc: Peter.Yin@quantatw.com, Patrick_NC_Lin@wiwynn.com,
Bonnie_Lo@wiwynn.com, DELPHINE_CHIU@wiwynn.com,
bmc-sw@aspeedtech.com, chnguyen@amperecomputing.com
Subject: Re: [PATCH v2 1/3] ARM: dts: aspeed: Add WDT controller into alias field
Date: Tue, 29 Oct 2024 10:25:20 +1030 [thread overview]
Message-ID: <0b51600b1308d64e362b771f1bf8adde2fa0fc19.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20241028024813.2416962-2-chin-ting_kuo@aspeedtech.com>
On Mon, 2024-10-28 at 10:48 +0800, Chin-Ting Kuo wrote:
> Add WDT controller into alias field. After that, WDT index,
> used to distinguish different WDT controllers in the driver,
> can be gotten by using of_alias_get_id dts API.
I feel it would be less brittle if we encode the mapping in the driver?
Based on reg the driver can derive the watchdog index. That way there's
no constraint on how the platform architect arranges the aliases for
the watchdogs (if they define them at all).
Andrew
next prev parent reply other threads:[~2024-10-28 23:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 2:48 [PATCH v2 0/3] Update ASPEED WDT bootstatus Chin-Ting Kuo
2024-10-28 2:48 ` [PATCH v2 1/3] ARM: dts: aspeed: Add WDT controller into alias field Chin-Ting Kuo
2024-10-28 23:55 ` Andrew Jeffery [this message]
2024-10-29 2:32 ` Chin-Ting Kuo
2024-10-28 2:48 ` [PATCH v2 2/3] watchdog: aspeed: Update bootstatus handling Chin-Ting Kuo
2024-10-28 2:48 ` [PATCH v2 3/3] watchdog: aspeed: Add support for SW restart Chin-Ting Kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b51600b1308d64e362b771f1bf8adde2fa0fc19.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=Bonnie_Lo@wiwynn.com \
--cc=DELPHINE_CHIU@wiwynn.com \
--cc=Patrick_NC_Lin@wiwynn.com \
--cc=Peter.Yin@quantatw.com \
--cc=bmc-sw@aspeedtech.com \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=chnguyen@amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=patrick@stwcx.xyz \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox