* [PATCH RFT] watchdog: gef_wdt.c: add missing remove callback
@ 2012-11-02 18:15 Devendra Naga
2013-01-30 19:13 ` Wim Van Sebroeck
0 siblings, 1 reply; 2+ messages in thread
From: Devendra Naga @ 2012-11-02 18:15 UTC (permalink / raw)
To: Wim Van Sebroeck, linux-watchdog; +Cc: Devendra Naga
this module missed a remove callback in the platform ops.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
Hi,
I didn't compile it even, i didn't have any crosstoolchain
drivers/watchdog/gef_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/gef_wdt.c b/drivers/watchdog/gef_wdt.c
index 17f4cae..3e360ed 100644
--- a/drivers/watchdog/gef_wdt.c
+++ b/drivers/watchdog/gef_wdt.c
@@ -310,6 +310,7 @@ static struct platform_driver gef_wdt_driver = {
.of_match_table = gef_wdt_ids,
},
.probe = gef_wdt_probe,
+ .remove = gef_wdt_remove,
};
static int __init gef_wdt_init(void)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH RFT] watchdog: gef_wdt.c: add missing remove callback
2012-11-02 18:15 [PATCH RFT] watchdog: gef_wdt.c: add missing remove callback Devendra Naga
@ 2013-01-30 19:13 ` Wim Van Sebroeck
0 siblings, 0 replies; 2+ messages in thread
From: Wim Van Sebroeck @ 2013-01-30 19:13 UTC (permalink / raw)
To: Devendra Naga; +Cc: linux-watchdog
Hi
> this module missed a remove callback in the platform ops.
>
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
> ---
> Hi,
>
> I didn't compile it even, i didn't have any crosstoolchain
>
> drivers/watchdog/gef_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/gef_wdt.c b/drivers/watchdog/gef_wdt.c
> index 17f4cae..3e360ed 100644
> --- a/drivers/watchdog/gef_wdt.c
> +++ b/drivers/watchdog/gef_wdt.c
> @@ -310,6 +310,7 @@ static struct platform_driver gef_wdt_driver = {
> .of_match_table = gef_wdt_ids,
> },
> .probe = gef_wdt_probe,
> + .remove = gef_wdt_remove,
> };
>
> static int __init gef_wdt_init(void)
Added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-30 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-02 18:15 [PATCH RFT] watchdog: gef_wdt.c: add missing remove callback Devendra Naga
2013-01-30 19:13 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).