From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:52069 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755454Ab2KVSpt (ORCPT ); Thu, 22 Nov 2012 13:45:49 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so6031325pbc.19 for ; Thu, 22 Nov 2012 10:45:49 -0800 (PST) From: Tushar Behera To: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org Cc: wim@iguana.be, patches@linaro.org, Anthony.Olech@diasemi.com Subject: [PATCH] watchdog: da9052: Fix invalid free of devm_ allocated data Date: Thu, 22 Nov 2012 10:13:04 +0530 Message-Id: <1353559384-26570-1-git-send-email-tushar.behera@linaro.org> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org It is not required to free devm_ allocated data. Since kref_put needs a valid release function, da9052_wdt_release_resources() is not deleted. Fixes following warning. drivers/watchdog/da9052_wdt.c:59:1-6: WARNING: invalid free of devm_ allocated data Signed-off-by: Tushar Behera --- drivers/watchdog/da9052_wdt.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c index f7abbae..20071de 100644 --- a/drivers/watchdog/da9052_wdt.c +++ b/drivers/watchdog/da9052_wdt.c @@ -53,10 +53,6 @@ static const struct { static void da9052_wdt_release_resources(struct kref *r) { - struct da9052_wdt_data *driver_data = - container_of(r, struct da9052_wdt_data, kref); - - kfree(driver_data); } static int da9052_wdt_set_timeout(struct watchdog_device *wdt_dev, -- 1.7.4.1