From: Wolfram Sang <w.sang@pengutronix.de>
To: linux-watchdog@vger.kernel.org
Cc: Wim Van Sebroeck <wim@iguana.be>, Wolfram Sang <w.sang@pengutronix.de>
Subject: [PATCH 0/3] improved watchdog driver for STMP3xyz/imx23/imx28
Date: Fri, 4 Jan 2013 14:58:46 +0100 [thread overview]
Message-ID: <1357307929-1666-1-git-send-email-w.sang@pengutronix.de> (raw)
Geez, this should have been sent a year ago but it dropped off somehow.
Introduce a new user of the watchdog framework. This is a rewritten driver
for STMP and imx23/28: Quoting Patch 2/3 for the motivation of a rewrite:
===
Replace the existing STMP3xxx driver because it has enough drawbacks
that a rewrite is apropriate. The new driver is designed to use the
watchdog framework which makes it a lot smaller and avoids open coding
the watchdog API again. It also uses now an explicitly exported function
from the RTC driver to set up its registers (the old driver silently
reused the hopefully(!) already remapped RTC registers). Also, this
driver is mach independent, while the old one depends on a mach replaced
by another one a year ago. Since the user interface is still the
standard watchdog API, users don't need to adapt.
===
The first patch adds an accessor routine to the RTC-driver which can hopefully
go via the watchdog-tree as well (asking for Andrew's ack here). It is needed
because the old driver silently assumed its IO area to be already remapped by
the RTC driver. The second patch adds the new driver, the third removes the old
one. The old driver was broken (= not compilable, no arch for it) anyhow, so
there cannot be any regression. Based on 3.8-rc2 and tested on various MX28
boards.
Thanks,
Wolfram
Wolfram Sang (3):
rtc: stmp3xxx: add wdt-accessor function
watchdog: add new driver for STMP3xxx and i.MX23/28
watchdog: remove old STMP3xxx driver
drivers/rtc/rtc-stmp3xxx.c | 64 ++++++++
drivers/watchdog/Kconfig | 13 +-
drivers/watchdog/Makefile | 2 +-
drivers/watchdog/stmp3xxx_rtc_wdt.c | 111 ++++++++++++++
drivers/watchdog/stmp3xxx_wdt.c | 288 -----------------------------------
include/linux/stmp3xxx_rtc_wdt.h | 15 ++
6 files changed, 198 insertions(+), 295 deletions(-)
create mode 100644 drivers/watchdog/stmp3xxx_rtc_wdt.c
delete mode 100644 drivers/watchdog/stmp3xxx_wdt.c
create mode 100644 include/linux/stmp3xxx_rtc_wdt.h
--
1.7.10.4
next reply other threads:[~2013-01-04 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 13:58 Wolfram Sang [this message]
2013-01-04 13:58 ` [PATCH 1/3] rtc: stmp3xxx: add wdt-accessor function Wolfram Sang
2013-01-07 23:53 ` Andrew Morton
2013-01-04 13:58 ` [PATCH 2/3] watchdog: add new driver for STMP3xxx and i.MX23/28 Wolfram Sang
2013-01-04 13:58 ` [PATCH 3/3] watchdog: remove old STMP3xxx driver Wolfram Sang
2013-01-29 16:26 ` [PATCH 0/3] improved watchdog driver for STMP3xyz/imx23/imx28 Wolfram Sang
2013-01-30 21:13 ` Wim Van Sebroeck
[not found] <515EF92C.1080609@digi.com>
2013-04-05 16:22 ` Hector Palacios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357307929-1666-1-git-send-email-w.sang@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).