From: Takahisa Tanaka <mc74hc00@gmail.com>
To: linux-watchdog@vger.kernel.org
Cc: Wim Van Sebroeck <wim@iguana.be>,
Paul Menzel <paulepanter@users.sourceforge.net>,
Arkadiusz Miskiewicz <arekm@maven.pl>,
Bjorn Helgaas <bhelgaas@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Nieder <jrnieder@gmail.com>,
linux-kernel@vger.kernel.org,
Florian Mickler <florian@mickler.org>,
Joseph Salisbury <joseph.salisbury@canonical.com>,
Joseph Salisbury <josephtsalisbury@gmail.com>,
Takahisa Tanaka <mc74hc00@gmail.com>
Subject: [PATCH] sp5100_tco: Fix the AcpiMmioSel bitmask value
Date: Sun, 3 Mar 2013 14:48:00 +0900 [thread overview]
Message-ID: <1362289680-3527-1-git-send-email-mc74hc00@gmail.com> (raw)
The AcpiMmioSel bit is the bit1 in AcpiMmioEn register, but, current
sp5100_tco driver was using bit2.
The sp5100_tco driver expects zero as a value of AcpiMmioSel (bit1).
fortunately, The problem didn't occur by this typo, because the default
value of misused bit2 is zero. However, the sp5100_tco driver should use
the correct bitmask value.
Signed-off-by: Takahisa Tanaka <mc74hc00@gmail.com>
---
drivers/watchdog/sp5100_tco.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/sp5100_tco.h b/drivers/watchdog/sp5100_tco.h
index 71594a0..2b28c00 100644
--- a/drivers/watchdog/sp5100_tco.h
+++ b/drivers/watchdog/sp5100_tco.h
@@ -57,7 +57,7 @@
#define SB800_PM_WATCHDOG_DISABLE (1 << 2)
#define SB800_PM_WATCHDOG_SECOND_RES (3 << 0)
#define SB800_ACPI_MMIO_DECODE_EN (1 << 0)
-#define SB800_ACPI_MMIO_SEL (1 << 2)
+#define SB800_ACPI_MMIO_SEL (1 << 1)
#define SB800_PM_WDT_MMIO_OFFSET 0xB00
--
1.8.1.4
next reply other threads:[~2013-03-03 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-03 5:48 Takahisa Tanaka [this message]
2013-03-03 9:10 ` [PATCH v2] sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2 Paul Menzel
2013-03-07 12:17 ` Tanaka Takahisa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362289680-3527-1-git-send-email-mc74hc00@gmail.com \
--to=mc74hc00@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arekm@maven.pl \
--cc=bhelgaas@google.com \
--cc=florian@mickler.org \
--cc=joseph.salisbury@canonical.com \
--cc=josephtsalisbury@gmail.com \
--cc=jrnieder@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=paulepanter@users.sourceforge.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox