From: Joe Perches <joe@perches.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
wim@iguana.be, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, grant.likely@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
heiko@sntech.de, yingjoe.chen@gmail.com, ibanezchen@gmail.com,
greta.zhang@mediatek.com, eddie.huang@mediatek.com,
wens@csie.org
Subject: Re: [PATCH v3 1/2] watchdog: Add driver for Mediatek watchdog
Date: Wed, 17 Dec 2014 17:47:45 -0800 [thread overview]
Message-ID: <1418867265.28384.6.camel@perches.com> (raw)
In-Reply-To: <20141218013717.GA9855@roeck-us.net>
On Wed, 2014-12-17 at 17:37 -0800, Guenter Roeck wrote:
> On Wed, Dec 17, 2014 at 10:18:04PM +0100, Matthias Brugger wrote:
> > This patch adds a driver for the Mediatek SoC integrated
> > watchdog. This driver supports watchdog and software reset
> > for mt65xx and mt81xx SoCs.
[]
> > diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
[]
> > +static int mtk_reset_handler(struct notifier_block *this, unsigned long mode,
> > + void *cmd)
> > +{
> > + struct mtk_wdt_dev *mtk_wdt = container_of(this,
> > + struct mtk_wdt_dev,
> > + restart_handler);
> I don't really understand the indentation logic you are using.
> Can you make it consistent ?
>
> I would suggest to align with '(' in the previous line.
Another way is to separate the declaration and the set
struct mtk_wdt_dev *mtk_wdt;
void __iomem *wdt_base;
mtk_wdt = container_of(this, struct mtk_wdt_dev, restart_handler);
wdt_base = mtk_wdt->wdt_base;
next prev parent reply other threads:[~2014-12-18 1:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 21:18 [PATCH v3 0/2] ARM: mediatek: Add watchdog driver Matthias Brugger
2014-12-17 21:18 ` [PATCH v3 1/2] watchdog: Add driver for Mediatek watchdog Matthias Brugger
2014-12-18 1:37 ` Guenter Roeck
2014-12-18 1:47 ` Joe Perches [this message]
2014-12-17 21:18 ` [PATCH v3 2/2] ARM: mediatek: dts: Add bindings for watchdog Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418867265.28384.6.camel@perches.com \
--to=joe@perches.com \
--cc=eddie.huang@mediatek.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=greta.zhang@mediatek.com \
--cc=heiko@sntech.de \
--cc=ibanezchen@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wim@iguana.be \
--cc=yingjoe.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox