From: Philipp Zabel <p.zabel@pengutronix.de>
To: "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
Wim Van Sebroeck <wim@iguana.be>,
Support Opensource <Support.Opensource@diasemi.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH 1/2] watchdog: da9063: Ping watchdog only during allowed time window
Date: Fri, 07 Aug 2015 12:17:53 +0200 [thread overview]
Message-ID: <1438942673.3638.16.camel@pengutronix.de> (raw)
In-Reply-To: <2E89032DDAA8B9408CB92943514A0337AB569C3B@SW-EX-MBX01.diasemi.com>
Hi Adam,
Am Freitag, den 07.08.2015, 10:13 +0000 schrieb Opensource [Adam
Thomson]:
> On August 06, 2015 17:37, Philipp Zabel wrote:
>
> > There is a cooldown period after watchdog timer setup, and also after each
> > watchdog ping. If a ping is issued too early, the watchdog triggers the
> > watchdog error condition and causes a system reset.
> >
> > The 256 ms period length is a best guess based on the same value being used
> > for the DA9053 predecessor PMIC and experiments that have shown 200 ms are
> > not enough to avoid the error.
> >
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> My colleague Stephen is out of office for the next two weeks, but really I
> think he should review these two patches given his knowledge of the device. If
> you can hold off until then, he should be able to provide feedback.
Absolutely, thank you for the heads-up.
regards
Philipp
next prev parent reply other threads:[~2015-08-07 10:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 16:36 [PATCH 1/2] watchdog: da9063: Ping watchdog only during allowed time window Philipp Zabel
2015-08-06 16:36 ` [PATCH 2/2] watchdog: da9063: Disable and wait before changing timeout Philipp Zabel
2015-08-07 13:40 ` Guenter Roeck
2015-08-07 17:09 ` Philipp Zabel
2015-08-07 10:13 ` [PATCH 1/2] watchdog: da9063: Ping watchdog only during allowed time window Opensource [Adam Thomson]
2015-08-07 10:17 ` Philipp Zabel [this message]
2015-08-24 13:39 ` Opensource [Steve Twiss]
2015-08-07 13:36 ` Guenter Roeck
2015-08-07 17:08 ` Philipp Zabel
2015-08-07 17:33 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438942673.3638.16.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=kernel@pengutronix.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox