From: Guenter Roeck <linux@roeck-us.net>
To: linux-watchdog@vger.kernel.org
Cc: Wim Van Sebroeck <wim@iguana.be>,
Damien Riegel <damien.riegel@savoirfairelinux.com>,
linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers
Date: Thu, 24 Dec 2015 14:21:59 -0800 [thread overview]
Message-ID: <1450995724-17758-1-git-send-email-linux@roeck-us.net> (raw)
The 'dev' variable in watchdog drivers has a different lifetime than the
watchdog character device and should therefore not be used by watchdog
drivers.
Some of the drivers use the variable to print kernel messages. Those
messages are either dropped or changed to use the parent device.
One driver sets the variable during initialization to the watchdog
driver's parent device, which is wrong and was removed.
v2: Use parent device for dev_XXX messages instead of pr_XXX.
next reply other threads:[~2015-12-24 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 22:21 Guenter Roeck [this message]
2015-12-24 22:22 ` [PATCH v2 1/5] watchdog: bcm2835_wdt: Drop log message if watchdog is stopped Guenter Roeck
2015-12-24 22:22 ` [PATCH v2 2/5] watchdog: tangox: Print info message using pointer to platform device Guenter Roeck
2015-12-24 22:22 ` [PATCH v2 3/5] watchdog: gpio: Do not use device pointer from struct watchdog_device Guenter Roeck
2015-12-24 22:22 ` [PATCH v2 4/5] watchdog: mena21: " Guenter Roeck
2015-12-24 22:22 ` [PATCH v2 5/5] watchdog: qcom-wdt: Do not set 'dev' in " Guenter Roeck
2015-12-28 22:15 ` [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers Wim Van Sebroeck
2015-12-29 0:00 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450995724-17758-1-git-send-email-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=damien.riegel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).